Shared heap enhancements for Interpreter and AOT #4400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with main
…date function signature
- preallocated shared heap and shared heap chain - update preallocated shared heap and shared heap chain sample and document - shared heap unit test and sample - update document and build script Co-authored-by: liang.he <[email protected]>
* shared heap enhancement: modify memory check for aot_check_memory_overflow to accomodate shared heap chain * shared heap enhancement in AOT * use alloca for func ctx shared heap cache value * use correct alloca for func ctx shared heap cache value * enable shared heap chain aot test and bug fix * Fix a missing argument on 32bits platform, still has the shared heap chain iteration problem * Fix shared heap chain iteration problem on 32bits platform * fix AOT bulk memory bounds checks compliation issue * fix AOT bulk memory bounds checks on 64 bits platform * refactor aot memory check * refactor AOT bulk memory bounds checks * add more unit test for shared heap * finished organizing unit test for shared heap and enable x86_32 for shared heap unit test * cover a corner case for bulk memory overflow check * try func call to replace shared heap chain traverse * fix compilation error in JIT and potentially load nullptr * add option for wamrc to enable single shared heap/multi shared heap, and update shared heap unit tests and sample * cr suggestions: 1. check potiential underflow 2. refactor and use separate function for bulk memory and normal memroy 3. static assert 4. add more comments 5. remove unused code
TianlongLiang
requested review from
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
TianlongLiang
commented
Jun 27, 2025
| @@ -974,29 +1222,17 @@ wasm_runtime_addr_native_to_app(WASMModuleInstanceCommon *module_inst_comm, | |||
|
|
|||
| bounds_checks = is_bounds_checks_enabled(module_inst_comm); | |||
|
|
|||
There was a problem hiding this comment.
this logic should moved to cmake config, to double check
lum1n0us
reviewed
Jun 30, 2025
| load_wasm(char *wasm_file_tested, unsigned int app_heap_size) | ||
| static void | ||
| destroy_module_env(struct ret_env module_env); | ||
|
|
There was a problem hiding this comment.
Might want to use setup() and teardown() to simplify and unify test procedures.
TianlongLiang
commented
Jun 30, 2025
| goto fail; \ | ||
| } \ | ||
| } while (0) | ||
|
|
||
| static bool | ||
| create_shared_heap_info(AOTCompContext *comp_ctx, AOTFuncContext *func_ctx) |
There was a problem hiding this comment.
In the future, maybe should update func ctx shared heap alloca value back to module instance extra when the function end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For interpreter and AOT mode: