Turn warnings into errors in CI #4397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lum1n0us
commented
Jun 20, 2025
lum1n0us
commented
- Apply global warnings in config_common.cmake instead of maintaining them in separate files.
- Enable errors during CI when building iwasm and wamrc
lum1n0us
force-pushed
the
fix/global_wanring_options
branch
8 times, most recently
from
f5a4210 to
b1a3ca5
Compare
- Apply global warnings in config_common.cmake instead of maintaining them in separate files. - Enable errors during CI when building iwasm and wamrc. - Since GCC and Clang are the default compilers on Ubuntu and macOS, enabling `-Werror` on both platforms can be treated as checking with different compilers.
lum1n0us
force-pushed
the
fix/global_wanring_options
branch
from
f553bd8 to
c3cb9e0
Compare
lum1n0us
requested review from
loganek,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
loganek
reviewed
Jul 1, 2025
| # Remove the extra spaces for better make log | ||
| string (REGEX REPLACE " *" " " CMAKE_C_FLAGS ${CMAKE_C_FLAGS}) | ||
| endif() | ||
|
|
||
| # global additional warnings. Keep those options consistent with config_common.cmake. | ||
| if (MSVC) |
There was a problem hiding this comment.
feels like a duplication of config_common.cmake - would it make sense to create warnings.cmake file and move the common code there, so it can be included when needed?
yamt
reviewed
Jul 3, 2025
| # | ||
| # -fpermissive causes warnings like "-fpermissive is valid for C++/ObjC++ but not for C" | ||
| # | ||
| # _Static_assert and _Alignof requires c11 or later |
There was a problem hiding this comment.
is this c11 comment intended to be here? why?
There was a problem hiding this comment.
Thank you for reminding me. I am inclined to start a discussion here, as we are using _Static_assert and _Alignof(and/or atomic), primarily in WASI. Do we need to designate C11 as our standard, or should we continue using a lower version, like C99, for cross-platform compatibility?
code in wamr-compiler/CMakeLists.txt
if (WAMR_BUILD_LIBC_WASI EQUAL 1)
# Enable _Static_assert
set (CMAKE_C_STANDARD 11)
if (MSVC)
add_compile_options(/experimental:c11atomics)
endif()
else()
set (CMAKE_C_STANDARD 99)
endif()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.