Skip to content

Dev/zephyr file socket #4377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev/zephyr_file_socket
Choose a base branch
from

Conversation

srberard
Copy link
Contributor

This is still a work in progress, but committing now to make the code available for others who might want to review, test, or build on it while it's still being developed.

Fixes include the following (Zephyr target):

  • Improved Socket support
  • Fixes to stdout/console output
  • Fixes for fstat, fstatat, and unlink
  • Code changes to fix numerous build warnings.

This branch still needs to be updated to the latest trunk and validation on non-Zephyr platforms.

@lum1n0us
Copy link
Collaborator

@banana-sun Please conduct a test with this PR, thanks.

@lum1n0us
Copy link
Collaborator

@srberard There are so many commits that make reviews difficult. Do you think a rebase (targeting main) for bytecodealliance:dev/zephyr_file_socket would make it easier?

@srberard
Copy link
Contributor Author

@srberard There are so many commits that make reviews difficult. Do you think a rebase (targeting main) for bytecodealliance:dev/zephyr_file_socket would make it easier?

I did rebase this a few weeks back off main. I can do that again, but I don't think that will reduce the commit list.

@lum1n0us lum1n0us mentioned this pull request Jun 18, 2025
6 tasks
@lum1n0us
Copy link
Collaborator

lum1n0us commented Jun 20, 2025

@srberard I've updated dev/zephyr_file_socket by merging the latest commits (up to 64ef369) from main via #4384. Please update this PR, or I can help by updating it directly. ⏩ #4406

@lum1n0us
Copy link
Collaborator

I've merged #4406. This PR should be rebased.

@lum1n0us
Copy link
Collaborator

FYI: #4406 (review)

@lum1n0us
Copy link
Collaborator

I guess 64fa157 needs to be merged.

@srberard
Copy link
Contributor Author

@lum1n0us I'm working on this today and will get these conflicts resolved.

@lum1n0us
Copy link
Collaborator

Thanks. Please be aware that I've merged #4406, and dev/zephyr_file_socket has been updated. This PR, #4377, needs a rebase.

readdir works but I think we have a memory leak somewhere
fd 0, 1, and 2 will always be supplied for standard streams. Unlinkat and renameat work exclusively based on supplied paths.
@srberard srberard force-pushed the dev/zephyr_file_socket branch from 64fa157 to 4ac15c4 Compare June 28, 2025 09:20
@srberard
Copy link
Contributor Author

All the review items identified so far have been address with one exception. This will require some refactoring. I will get this done shortly and update this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants