-
Notifications
You must be signed in to change notification settings - Fork 703
Dev/zephyr file socket #4377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/zephyr_file_socket
Are you sure you want to change the base?
Dev/zephyr file socket #4377
Conversation
@banana-sun Please conduct a test with this PR, thanks. |
@srberard There are so many commits that make reviews difficult. Do you think a rebase (targeting main) for bytecodealliance:dev/zephyr_file_socket would make it easier? |
I did rebase this a few weeks back off main. I can do that again, but I don't think that will reduce the commit list. |
I've merged #4406. This PR should be rebased. |
FYI: #4406 (review) |
I guess 64fa157 needs to be merged. |
@lum1n0us I'm working on this today and will get these conflicts resolved. |
readdir works but I think we have a memory leak somewhere
fd 0, 1, and 2 will always be supplied for standard streams. Unlinkat and renameat work exclusively based on supplied paths.
64fa157
to
4ac15c4
Compare
All the review items identified so far have been address with one exception. This will require some refactoring. I will get this done shortly and update this branch. |
This is still a work in progress, but committing now to make the code available for others who might want to review, test, or build on it while it's still being developed.
Fixes include the following (Zephyr target):
This branch still needs to be updated to the latest trunk and validation on non-Zephyr platforms.