Skip to content

Deprecate setup.py, setup.cfg and use pyproject.toml#81

Merged
bwhmather merged 11 commits into
bwhmather:masterfrom
cgahr:pyproject-toml
Apr 26, 2023
Merged

Deprecate setup.py, setup.cfg and use pyproject.toml#81
bwhmather merged 11 commits into
bwhmather:masterfrom
cgahr:pyproject-toml

Conversation

@cgahr

@cgahr cgahr commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator
  1. I excluded test_data/samples/* from being run by black, isort and mypy
  2. This allows me to run black, isort and mypy for all files and I can remove the configuration of these 3 tools from tox.ini and github ci. Most importantly, there is no explicit usage of setup.py anymore
  3. Since setup.py is not used anymore, I removed it. Its code (as far as I can see) was not necessary.
  4. I moved all configurations from setup.cfg to pyproject.toml.

For a more in-depth discussion see #79

@cgahr cgahr mentioned this pull request Apr 25, 2023
@cgahr

cgahr commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator Author

tox doesn't fail now!

Comment thread tox.ini
@bwhmather bwhmather requested a review from jgberry April 25, 2023 21:30
Comment thread README.rst
bwhmather
bwhmather previously approved these changes Apr 25, 2023

@bwhmather bwhmather left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this. Will need to rebase once #80 is in to get CI to pass.

@jgberry

jgberry commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator

@cgahr I don't think this plays nicely with .github/workflows/release.yaml. Probably need some tweaking there.

@cgahr

cgahr commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator Author

@cgahr I don't think this plays nicely with .github/workflows/release.yaml. Probably need some tweaking there.

You are correct. Will fix this tomorrow.

@bwhmather

Copy link
Copy Markdown
Owner

@cgahr I don't think this plays nicely with .github/workflows/release.yaml. Probably need some tweaking there.

Good spot.

@bwhmather bwhmather merged commit 5dd41a5 into bwhmather:master Apr 26, 2023
@coveralls

coveralls commented Oct 3, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 4806040566

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.225%

Totals Coverage Status
Change from base Build 4802506014: 0.0%
Covered Lines: 1273
Relevant Lines: 1296

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants