22 descriptor pools and sets #7
Conversation
matthew-russo
force-pushed
the
22_descriptor_pools_and_sets
branch
from
18ef3d7 to
127e6fd
Compare
…and_creation 21 uniform buffer definition and creation
Create Github Action (build & lint)
…t creation, updates create_command_buffers to map memory to our uniform buffer, reverses the order of vertices drawn
matthew-russo
force-pushed
the
22_descriptor_pools_and_sets
branch
from
127e6fd to
63b7d46
Compare
matthew-russo
force-pushed
the
22_descriptor_pools_and_sets
branch
from
63b7d46 to
5716979
Compare
|
Found the issue on MacOS. I'm pretty sure its this: vulkano-rs/vulkano#1135. I made some changes in the pr, and would like to get your feedback on it. Essentially we were chaining a ton of futures as you said and then the image stutters when the GPU catches up since we never actually waited for them. I added a call to wait for the future and it seems to clear up the stutter on my machine. I'm not sure if this means we can just get rid of previous_frame_end altogether now that we're waiting on the future or not. I'm still no expert on vulkano so going to keep investigating but wanted to get your input |
|
Fixes the issue for me too. Not sure about the I also wonder if this should be marked as a hack and restricted to macOS ( |
|
Noted. Will make those changes. But I also had a chance to test on a different mac machine today and found it didnt work -- just a black screen pops up. It only happens on 22 and after so I'm going to look into whats going on with that. What model mac were you able to test on? I found it worked on a Macbook Pro 2015 but not on a Macbook Pro 2018. Going to look into whether other people have had issues and what the hardware differences are. |
|
Weird. After updating the vulkan sdk from 1.1.92.1 to 1.1.97.0, everything now works on the 2018 Pro. Not sure if its worth digging into this more? |
|
I've got a Macbook Pro 2015 with Vulkan SDK 1.1.82. I'd say it's fine if it works with the latest SDK. Perhaps we can add a note to the readme to make to use the latest SDK on macOS. |
…_and_creation switches from glm to cgmath;
|
Looks good (apart from that small conflict). I think I'll find time to finish reviewing this and a few more chapters in a week or two. |
bwasty
force-pushed
the
22_descriptor_pools_and_sets
branch
from
266867b to
adc600d
Compare
| fn create_descriptor_pool(graphics_pipeline: &Arc<GraphicsPipelineAbstract + Send + Sync>) | ||
| -> Arc<Mutex<FixedSizeDescriptorSetsPool<Arc<GraphicsPipelineAbstract + Send + Sync>>>> | ||
| { | ||
| Arc::new( |
There was a problem hiding this comment.
Any reason for the Arc? Seems unnecessary when already using a mutex, and it works fine if I remove it.
There was a problem hiding this comment.
Sorry for the delay in responding. No reason -- I was just in the habit of wrapping everything in an Arc. I have updated the PR accordingly
matthew-russo
force-pushed
the
22_descriptor_pools_and_sets
branch
from
6a4517c to
bfef11d
Compare
this is the second half of the uniform buffer section with descriptor pools and sets