Fix bug introduced in 7.5 with interact menu on self.#27
Draft
Chryssie wants to merge 1 commit intobvbohnen:masterfrom
Draft
Fix bug introduced in 7.5 with interact menu on self.#27Chryssie wants to merge 1 commit intobvbohnen:masterfrom
Chryssie wants to merge 1 commit intobvbohnen:masterfrom
Conversation
ad7807f to
a9312cc
Compare
Author
|
Due note, I can't figure out how to get the the plugins working locally with this setup so I can't test it as-is. However, I have been able to test it with the addition of #26 which I can get working locally and both the new (a9312cc) and the previous change (ad7807f) resolve the issue, although the new change doesn't require duplicating a bunch of Egosoft code. |
Author
|
Unfortunately overriding the function causes an error, may need to revert to ad7807f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the right-click menu issue. It appears that
OnlineGetUserItems()returnsnilin some cases causing thenot onlineitems[ware]check inmenu_interactmenu.luaon line 5097 (of the core game, not the mod) to throw. Not sure if this is an Egosoft bug or something downstream of delaying the render/draw but this does fix the issue. May be possible to fix it differently though in a better way.This just explictly adds
onlineitems == nil orcheck to guard against that case.