Skip to content

Release GIL when calling potentially-blocking functions #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Release GIL when calling potentially-blocking functions #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ PYBIND11_MODULE(NDIlib, m) {
[](py::capsule instance, uint32_t timeout_in_ms) {
auto p_instance =
static_cast<NDIlib_find_instance_type *>(instance.get_pointer());
py::gil_scoped_release release;
return NDIlib_find_wait_for_sources(p_instance, timeout_in_ms);
},
py::arg("instance"), py::arg("timeout_in_ms"));
Expand Down Expand Up @@ -458,6 +459,7 @@ PYBIND11_MODULE(NDIlib, m) {
[](py::capsule instance, uint32_t timeout_in_ms) {
auto p_instance =
static_cast<NDIlib_recv_instance_type *>(instance.get_pointer());
py::gil_scoped_release release;
NDIlib_video_frame_v2_t video_frame;
NDIlib_audio_frame_v2_t audio_frame;
NDIlib_metadata_frame_t metadata_frame;
Expand All @@ -475,6 +477,7 @@ PYBIND11_MODULE(NDIlib, m) {
[](py::capsule instance, uint32_t timeout_in_ms) {
auto p_instance =
static_cast<NDIlib_recv_instance_type *>(instance.get_pointer());
py::gil_scoped_release release;
NDIlib_video_frame_v2_t video_frame;
NDIlib_audio_frame_v3_t audio_frame;
NDIlib_metadata_frame_t metadata_frame;
Expand Down Expand Up @@ -963,6 +966,7 @@ PYBIND11_MODULE(NDIlib, m) {
uint32_t timeout_in_ms) {
auto p_instance =
static_cast<NDIlib_send_instance_type *>(instance.get_pointer());
py::gil_scoped_release release;
NDIlib_send_capture(p_instance, p_metadata, timeout_in_ms);
},
py::arg("instance"), py::arg("metadata"), py::arg("timeout_in_ms"));
Expand All @@ -982,6 +986,7 @@ PYBIND11_MODULE(NDIlib, m) {
uint32_t timeout_in_ms) {
auto p_instance =
static_cast<NDIlib_send_instance_type *>(instance.get_pointer());
py::gil_scoped_release release;
return NDIlib_send_get_tally(p_instance, p_tally, timeout_in_ms);
},
py::arg("instance"), py::arg("tally"), py::arg("timeout_in_ms"));
Expand All @@ -991,6 +996,7 @@ PYBIND11_MODULE(NDIlib, m) {
[](py::capsule instance, uint32_t timeout_in_ms) {
auto p_instance =
static_cast<NDIlib_send_instance_type *>(instance.get_pointer());
py::gil_scoped_release release;
return NDIlib_send_get_no_connections(p_instance, timeout_in_ms);
},
py::arg("instance"), py::arg("timeout_in_ms"));
Expand Down Expand Up @@ -1104,6 +1110,7 @@ PYBIND11_MODULE(NDIlib, m) {
[](py::capsule instance, uint32_t timeout_in_ms) {
auto p_instance =
static_cast<NDIlib_routing_instance_type *>(instance.get_pointer());
py::gil_scoped_release release;
return NDIlib_routing_get_no_connections(p_instance, timeout_in_ms);
},
py::arg("instance"), py::arg("timeout_in_ms"));
Expand Down