fix(rtl): auto-detect text direction in read, print and plain-text views#663
Open
shukiv wants to merge 1 commit into
Open
fix(rtl): auto-detect text direction in read, print and plain-text views#663shukiv wants to merge 1 commit into
shukiv wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The reader renders message bodies with the UI's direction, not the message's. With an RTL UI (Hebrew/Arabic/Persian), an English email is right-aligned; with an LTR UI, a Hebrew email is left-aligned. Mixed-language mail is wrong either way.
Fix
Add
dir="auto"in the three places a message body is rendered:autoresolves direction per block from its first strong character, so each paragraph aligns by its own content — an English paragraph stays LTR even inside an RTL UI, and vice-versa. Mixed-language messages render each block correctly.Three attributes, no logic or dependency changes; LTR-only mail is unaffected (
autoresolves to LTR).Testing
tscclean; lint clean (no new warnings)