Surface Detekt stderr output for detekt_test targets#212
Open
ryanulep wants to merge 2 commits into
Open
Conversation
ryanulep
changed the title
ryanulep
force-pushed
the
test_output
branch
4 times, most recently
from
b6ade69 to
43e95f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when Detekt runs as a test target, its stderr output is silently discarded. This PR captures stderr output to a dedicated file (
{name}_stderr.txt) and displays it in the Bazel runner script, consistent with how build targets already surface output.Changes:
--stderr-outputargument to pass a file path for capturing stderrresult.output()(stderr) to that file when running as a test target--stderr-outputfrom args passed through to DetektNote: We should look into providing a more succinct output similar to Error Prone (or at least the Detekt CLI) output.