Revert "Add support for custom URL templates (#202)"#211
Open
ryanulep wants to merge 1 commit into
Open
Conversation
This reverts commit ae314e3.
Bencodes
approved these changes
Mar 12, 2026
Bencodes
left a comment
Bencodes
left a comment
Contributor
There was a problem hiding this comment.
I'm not against supporting this since it offers a clearer usage pattern for people. The original comment was more noting that Bazel has pretty good support for URL manipulation that could be leveraged as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ae314e3.
This is unnecessary as
bazel_downloader.cfgcan be used instead.