Skip to content

Conversation

StephenHodgson
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 22:31
@StephenHodgson StephenHodgson requested a review from a team as a code owner August 7, 2025 22:31
Copilot

This comment was marked as outdated.

@StephenHodgson StephenHodgson marked this pull request as draft August 27, 2025 20:53
@StephenHodgson StephenHodgson marked this pull request as ready for review August 27, 2025 20:53
@StephenHodgson StephenHodgson requested a review from Copilot August 28, 2025 17:48
Copilot

This comment was marked as outdated.

@StephenHodgson StephenHodgson requested a review from Copilot August 29, 2025 22:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the unity-xcode-builder action to version 1.3.4 with significant improvements to platform handling, Xcode version management, and destination resolution. The changes focus on making the build process more robust and removing manual Xcode installation requirements.

  • Enhanced destination resolution with automatic platform detection and destination parsing
  • Improved Xcode version selection to exclude beta versions and require pre-installed versions
  • Added better platform SDK management and entitlements handling for macOS builds

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/xcode.ts Major refactoring with new destination resolution logic, platform download handling, and reorganized function structure
src/utilities.ts Added utility functions for regex pattern matching and glob-based file finding
src/index.ts Updated Xcode version selection to exclude beta versions and require pre-installed Xcode
src/XcodeProject.ts Reorganized constructor parameters and added new properties for archive/export paths
package.json Version bump to 1.3.4 and dependency updates
.github/workflows/validate.yml Enhanced validation workflow with better error handling and output verification

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant