Skip to content

Conversation

@joshedney
Copy link
Contributor

@joshedney joshedney commented Dec 9, 2025

Goal

Conditionally check if we're releasing via the environment variable RELEASING and exclude the test fixtures if it is set.

Testing

Covered by CI

I've also tested it locally, publishing to a local maven repo

@joshedney joshedney self-assigned this Dec 9, 2025
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Dec 9, 2025

Android notifier sizes

Format Size of apk (kB)
APK 614.94
APK with Bugsnag 745.86

Android notifier size impact

Format Size impact of Bugsnag (kB)
APK 130.92
Minified APK 55.88

Generated by 🚫 Danger

lemnik
lemnik previously approved these changes Dec 9, 2025
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YYChen01988
YYChen01988 previously approved these changes Dec 9, 2025
@joshedney joshedney dismissed stale reviews from YYChen01988 and lemnik via 12f4e60 December 9, 2025 09:26
lemnik
lemnik previously approved these changes Dec 15, 2025
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Pending CI

Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshedney joshedney merged commit beb8c32 into next Dec 18, 2025
22 checks passed
@joshedney joshedney deleted the je/plat-15239 branch December 18, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants