Phil/Background component bundle#235
Open
philcable wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't quite get there, but could be the start of a potential way forward for removing the reliance on
npm linkwhen building releases for BU Prepress.It adds a
browserifytask to Grunt for building a bundled version of the background component todist/components/. This version of the file is the one used when the background component is imported into blocks in BU Prepress.It also adds
grunt browserifyas part of thenpm run buildscript. (Integrating it as part ofnpm startcould be explored to smooth things out further if this seems like a viable approach.)Companion https://github.com/bu-ist/bu-prepress/pull/506.