wallet: restore imported XPub derivation - #1324
Open
yyforyongyu wants to merge 3 commits into
Open
Conversation
yyforyongyu
force-pushed
the
task-xpub-derivation
branch
from
August 14, 2026 18:30
116f023 to
799e4d4
Compare
yyforyongyu
commented
Aug 17, 2026
yyforyongyu
force-pushed
the
task-xpub-derivation
branch
3 times, most recently
from
August 18, 2026 17:06
20035a3 to
07721a1
Compare
yyforyongyu
marked this pull request as ready for review
August 18, 2026 18:46
yyforyongyu
force-pushed
the
task-xpub-derivation
branch
from
August 20, 2026 01:01
07721a1 to
e890de7
Compare
Add wallet-owned public derivation parameters that select accounts by portable name or BIP44 number. Change Signer.DerivePubKey to accept the selector, branch, and child index directly.
Exercise selector-bearing derivation against SQLite while locked. Prove name lookup cannot collide with a numbered account, and verify the exported Signer contract without importing database types.
Refuse private signing for numberless imported-XPub children before account or raw-address secret lookup. Preserve per-address signing only for true raw imports.
yyforyongyu
force-pushed
the
task-xpub-derivation
branch
from
August 20, 2026 06:53
e890de7 to
b84b927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accounts.
exposing backend account identifiers.
Change Description
Implements roadmap Task 337