Skip to content

fix(frontend): update navbar to match new design #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 26, 2025
Merged

fix(frontend): update navbar to match new design #35

merged 4 commits into from
Jul 26, 2025

Conversation

Aadityapoddar
Copy link
Contributor

Overview

  1. This PR fixes or fixes part of [Feature Request]: Enhance navbar component according to new designs. #28 .
  2. This PR does the following: add changes to the existing navbar to match the latest changes in the design, it adds a line animation to highlight the current active page. This pr also makes the navbar to adjust to different screen sizes.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

Navbar-new.mp4

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.

@Aadityapoddar
fix(frontend): update navbar to match new design
53e3429 
Add line animation to highlight the active page.

Make navbar responsive for all screen sizes.

Closes bsoc-bitbyte#28
@netlify Netlify
Copy link

netlify bot commented Jul 10, 2025 •
edited
Loading

✅ Deploy Preview for ydo-bsoc ready!

Name Link
🔨 Latest commit fa2fa0a
🔍 Latest deploy log https://app.netlify.com/projects/ydo-bsoc/deploys/687fbcbe1b86550008c4a95a
😎 Deploy Preview https://deploy-preview-35--ydo-bsoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Zapper9982
Copy link
Collaborator

Love this @Aadityapoddar well done it looks amazing and smooth going ahead and Merging ! Thanks

@Zapper9982
Copy link
Collaborator

@Aadityapoddar just one change though instead of going to /Account its intended to go to /profile just fix it

@Aadityapoddar
Copy link
Contributor Author

@Aadityapoddar just one change though instead of going to /Account its intended to go to /profile just fix it

I have fixed it. Is there any other change required?

@Om-Thorat
Copy link
Contributor

@Aadityapoddar can you resolve these conflicts thanks

@Om-Thorat Om-Thorat merged commit de41e16 into bsoc-bitbyte:main Jul 26, 2025
6 checks passed
@Om-Thorat Om-Thorat added Difficulty : Medium medium level issue BSoC'25 Created for BSoC'25 Difficulty : Easy easy level issue and removed Difficulty : Medium medium level issue labels Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BSoC'25 Created for BSoC'25 Difficulty : Easy easy level issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aadityapoddar @Zapper9982 @Om-Thorat