Skip to content

Conversation

@ShirshenduR
Copy link

Overview

  1. This PR fixes or fixes part of [Feature Request] [Backend]: Integrate Google Login with Organization Domain Restriction #3
  2. This PR does the following:
    In this PR I have added firebase auth for and login for both via registering and also by google sign in. Add the Exam-bud-firebase.json from Firebase console and setup both frontend and backend envs

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.

ritankarsaha and others added 30 commits May 26, 2025 01:44
…or-final

Fix bsoc-bitbyte#17: refactored the backend structure and applied apiResponse and asyncHandling throughout the project
fix: Bug fix uploading and deleting and naming upload files
@ShirshenduR
Copy link
Author

@ritankarsaha @harshiill please review I have not made the route protection part

@ritankarsaha
Copy link
Collaborator

@ShirshenduR pls fix conflcits and push a new commit, take care of linting errors too but that's okay, not a biggie, just go through commit message patterns you will get it.

Fix the conflicts. Also I need a demo or a proof of work to begin reviewing.

Comment on lines 8 to 9

CLOUDINARY_URL=cloudinary://<your_api_key>:<your_api_secret>@<product_environment_name>
CLOUDINARY_PUBLIC_ID=<product_environment_name>
CLOUDINARY_PUBLIC_ID=<product_environment_name>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Comment on lines 14 to 16
# Firebase Configuration
FIREBASE_PROJECT_ID=<your_firebase_project_id>
FIREBASE_SERVICE_ACCOUNT_KEY_PATH=<your_firebase_service_account_key_path>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls make updates in the doc or readme as well if they have sample env structure.

@ritankarsaha
Copy link
Collaborator

@ShirshenduR i need to review this in detail, an important PR.

WIll do tomorrow.
By then pls post a demo working video, and fix the conflicts, mostly good work giving detailed reviews tomorrow.

Good work !

fix(auth): Made auth using firebase and domain restriction

fix: auth

feat: added auth
@ShirshenduR
Copy link
Author

Screen.Recording.2025-07-25.at.5.01.32.AM.mov

@ShirshenduR ShirshenduR requested a review from ritankarsaha July 24, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.