Fix #12: added a home/ user onboarding page #45

LightCreator1007 · 2025-07-19T06:49:59Z

Overview

This PR fixes or fixes part of [Frontend] Implement User Onboarding / Home Page (Semester & Branch Selection) #12.
This PR does the following:
- Adds an onboarding page to greet the user.
- has options for brach and semester selection.
- removes user stories/ user comments from the original design mockup to provide a clean and clutter free UX.
- Adapts responsively to a wide range of screen sizes

Essential Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
"Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
The PR is made from a branch that's not called "main/master".

Proof that changes are correct

exambudHome.mp4

- added images and code snippets for clear understanding - explained certain aspects for beginners. Closes bsoc-bitbyte#33

- added revised header and footer designs as per figma - added sems and branches - removed user stories for a cleaner design and ux Closes bsoc-bitbyte#12

Closes bsoc-bitbyte#12

ritankarsaha · 2025-07-19T10:27:55Z

How did the checks run without me approving them lol ?

ritankarsaha · 2025-07-19T10:28:27Z

anywhoo looking into the pr and reviewing soon, nice work @LightCreator1007

ritankarsaha

these chnages were on your earlier pr too, just a thought did your make this pr branch from an earlier branch and not from main. ?

ritankarsaha · 2025-07-24T21:09:06Z

frontend/src/App.jsx

-    { path: '/' },
-    { path: '/home' },
-    { path: '/branch/:branchId' },
-    { path: '/branch/:branchId/semester/:semesterId' },
-    { path: '/branch/:branchId/semester/:semesterId/subject/:subjectId' },
-    { path: '/admin' },
-    { path: '/login' },
-    { path: '/signup' }
+  { path: "/" },
+  { path: "/home" },
+  { path: "/branch/:branchId" },
+  { path: "/branch/:branchId/semester/:semesterId" },
+  { path: "/branch/:branchId/semester/:semesterId/subject/:subjectId" },
+  { path: "/admin" },
+  { path: "/login" },
+  { path: "/signup" },


ritankarsaha · 2025-07-24T21:09:22Z

frontend/src/App.jsx

-import Loading from './utils/Global-Loading/Loading';
-import useRouteProgress from './hooks/useRouteProgress.js';
-import './styles/nprogress-custom.css';
-const LandingPage = lazy(() => import('./pages/landingPage/LandingPage'));
-const Home = lazy(() => import('./pages/Home'));
-const Branch = lazy(() => import('./pages/Branch'));
-const Semester = lazy(() => import('./pages/Semester'));
-const Subject = lazy(() => import('./pages/Subject'));
-const AdminDashboard = lazy(() => import('./pages/AdminDashboard'));
-const NotFound = lazy(() => import('./pages/404/NotFound'));
-const LoginPage = lazy(() => import('./pages/Login/Login'));
-const SignUp = lazy(() => import('./pages/SignUp/SignUp'));
+import Loading from "./utils/Global-Loading/Loading";
+import useRouteProgress from "./hooks/useRouteProgress.js";
+import "./styles/nprogress-custom.css";
+const LandingPage = lazy(() => import("./pages/landingPage/LandingPage"));
+const Home = lazy(() => import("./pages/Home/Home.jsx"));
+const Branch = lazy(() => import("./pages/Branch"));
+const Semester = lazy(() => import("./pages/Semester"));
+const Subject = lazy(() => import("./pages/Subject"));
+const AdminDashboard = lazy(() => import("./pages/AdminDashboard"));
+const NotFound = lazy(() => import("./pages/404/NotFound"));
+const LoginPage = lazy(() => import("./pages/Login/Login"));
+const SignUp = lazy(() => import("./pages/SignUp/SignUp"));

-import Header from './components/Header/Header';
-import Footer from './components/Footer/Footer';
+import Header from "./components/Header/Header";
+import Footer from "./components/Footer/Footer";


ritankarsaha · 2025-07-24T21:09:44Z

frontend/src/App.jsx

-    { path: '/' },
-    { path: '/home' },
-    { path: '/branch/:branchId' },
-    { path: '/branch/:branchId/semester/:semesterId' },
-    { path: '/branch/:branchId/semester/:semesterId/subject/:subjectId' },
-    { path: '/admin' },
-    { path: '/login' },
-    { path: '/signup' }
+  { path: "/" },
+  { path: "/home" },
+  { path: "/branch/:branchId" },
+  { path: "/branch/:branchId/semester/:semesterId" },
+  { path: "/branch/:branchId/semester/:semesterId/subject/:subjectId" },
+  { path: "/admin" },


why did u change the quotes lol ?

My formatter fr sorry...

ritankarsaha · 2025-07-24T21:10:32Z

frontend/src/App.jsx

-
-    const location = useLocation();
-    const matched = matchRoutes(routes, location.pathname);
-    const is404 = !matched;
-
-    useRouteProgress();
+  const location = useLocation();
+  const matched = matchRoutes(routes, location.pathname);
+  const is404 = !matched;
+
+  useRouteProgress();


un-necessary whitespace changes makes your PR very clouded and hard to review. Pls take care from next time.

ritankarsaha · 2025-07-24T21:11:54Z

frontend/src/App.jsx

-    return (
-        <>
-          {!is404 && <Header />}
-              <main className="main-content">
-                  <Suspense fallback={<Loading />}>
-                      <Routes>
-                        <Route path="/home" element={<Home />} />
-                        <Route path="/" element={<LandingPage />} />
-                        <Route path="/branch/:branchId" element={<Branch />} />
-                        <Route path="/branch/:branchId/semester/:semesterId" element={<Semester />} />
-                        <Route path="/branch/:branchId/semester/:semesterId/subject/:subjectId" element={<Subject />} />
-                        <Route path="/admin" element={<AdminDashboard />} />
-                        <Route path="/login" element={<LoginPage />} />
-                        <Route path="/signup" element={<SignUp />} /> 
-                        <Route path="*" element={<NotFound />}/>
-                      </Routes>
-                  </Suspense>
-              </main>
-            {!is404 && <Footer />}
-        </>
-    );
+  return (
+    <>
+      {!is404 && <Header />}
+      <main className="main-content">
+        <Suspense fallback={<Loading />}>
+          <Routes>
+            <Route path="/home" element={<Home />} />
+            <Route path="/" element={<LandingPage />} />
+            <Route path="/branch/:branchId" element={<Branch />} />
+            <Route
+              path="/branch/:branchId/semester/:semesterId"
+              element={<Semester />}
+            />


These changes are literally un-necessary, as Git shows whitespace changes as well, I now have to go through all these un-necessary whitespace updates to find and review the proper update.

Pls take care next time

ritankarsaha · 2025-07-24T21:14:32Z

frontend/src/components/Footer/Footer.css

-    --primary-accent: rgba(198, 213, 255, 1);
-    --secondary-accent: rgba(20, 45, 111, 1);
-    --tertiary-accent: rgba(255, 255, 255, 1);
-    --nav-accent: rgba(255, 255, 255, 0.8);
-    font-family: 'Urbanist', Avenir, Helvetica, Arial, sans-serif;
+  --primary-accent: rgba(198, 213, 255, 1);
+  --secondary-accent: rgba(20, 45, 111, 1);
+  --tertiary-accent: rgba(255, 255, 255, 1);
+  --nav-accent: rgba(255, 255, 255, 0.8);
+  font-family: "Urbanist", Avenir, Helvetica, Arial, sans-serif;
 }

-*, ::before, ::after {
-    box-sizing: border-box;
-    margin: 0;
-    padding: 0;
+*,
+::before,
+::after {
+  box-sizing: border-box;
+  margin: 0;
+  padding: 0;
 }

-
 html {
-    scrollbar-width: none;


CSS updates is to be checked by @harshiill but ig they are mostly ok

ritankarsaha · 2025-07-24T21:15:33Z

frontend/src/pages/landingPage/LandingPage.css

-    display: flex;
-    flex-direction: column;
-    justify-content: center;
-    align-items: center;
-    padding: 10px 27px;
-    gap: 10px;
-    width: 183px;
-    height: 44px;
-    background: var(--secondary-accent);
-    box-shadow: 0 5px 9px 2px rgba(0, 0, 0, 0.25);
-    border-radius: 35px;
-    color: white;
-    margin: 1rem auto;
-    transition: transform 0.3s ease;
+  display: flex;
+  flex-direction: column;
+  justify-content: center;
+  align-items: center;
+  padding: 10px 27px;
+  gap: 10px;
+  width: 183px;
+  height: 44px;
+  background: var(--secondary-accent);
+  box-shadow: 0 5px 9px 2px rgba(0, 0, 0, 0.25);
+  border-radius: 35px;
+  color: white;
+  margin: 1rem auto;
+  transition: transform 0.3s ease;


from next pr pls take note of all un-necessary whitespace updates

…boarding Fix bsoc-bitbyte#12: added a home/ user onboarding page

LightCreator1007 · 2025-07-25T20:12:33Z

these chnages were on your earlier pr too, just a thought did your make this pr branch from an earlier branch and not from main. ?

No I needed to make some changes to the header and footer stuff coz the main page layout and figma layout for those are a but different

LightCreator1007 added 8 commits July 16, 2025 22:46

docs: added steps for cloudinary setup in env file

611318e

- added images and code snippets for clear understanding - explained certain aspects for beginners. Closes bsoc-bitbyte#33

fix: amended typos and fixed package.json

245e8c6

fix: amended typos

4f89edd

fix: resolved merge conflicts

a643568

fix: resolved merge conflicts

3245925

feat: added user onboarding pages

3e7b5ee

- added revised header and footer designs as per figma - added sems and branches - removed user stories for a cleaner design and ux Closes bsoc-bitbyte#12

fix: resolved alignment issues

13b9f95

fix: fixed responsive behaviour

91a853b

Closes bsoc-bitbyte#12

ritankarsaha reviewed Jul 24, 2025

View reviewed changes

ritankarsaha approved these changes Jul 24, 2025

View reviewed changes

ritankarsaha merged commit 92adf4a into bsoc-bitbyte:main Jul 24, 2025
4 checks passed

ShirshenduR pushed a commit to ShirshenduR/Exam-Bud that referenced this pull request Jul 25, 2025

Merge pull request bsoc-bitbyte#45 from LightCreator1007/feat/user-on…

58b5a7c

…boarding Fix bsoc-bitbyte#12: added a home/ user onboarding page

ritankarsaha assigned LightCreator1007 Aug 17, 2025

ritankarsaha added BSoC'25 Created uring BSoC 2024 difficulty : Medium labels Aug 17, 2025

Fix #12: added a home/ user onboarding page #45

Fix #12: added a home/ user onboarding page #45

Uh oh!

Conversation

LightCreator1007 commented Jul 19, 2025

Overview

Essential Checklist

Proof that changes are correct

Uh oh!

ritankarsaha commented Jul 19, 2025

Uh oh!

ritankarsaha commented Jul 19, 2025

Uh oh!

ritankarsaha left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LightCreator1007 commented Jul 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants