Skip to content

Conversation

@parthdude07
Copy link

Overview

  1. This PR fixes or fixes part of [Frontend] Implement Course Listing Page UI #13 ].
  2. This PR does the following:
    This PR implements the course listing UI as part of the Exambud project. It introduces a responsive layout to display available courses, aligned with the design goals of issue [Frontend] Implement Course Listing Page UI #13. The goal is to provide users with a clean and intuitive interface for browsing course content.

✅ Designed and implemented the course listing UI based on Figma designs (with matching PNGs).

🔍 Added search functionality to each relevant component.

🛠️ Implemented error handling using try-catch and conditional rendering to prevent runtime errors.

🔄 Ensured all components are resilient and error-free, improving the overall robustness of the app.

These changes ensure the interface is clean, responsive, user-friendly, and reliable under various conditions.

Essential Checklist

  • The PR title starts with "Fix [Frontend] Implement Course Listing Page UI #13 : ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

Screen.Recording.2025-06-27.144708.1.mp4

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.

@parthdude07
Copy link
Author

parthdude07 commented Jul 2, 2025

@ritankarsaha how i solve this
merger conflict issue??

@parthdude07
Copy link
Author

@ritankarsaha @harshiill i had raised PR . kindly check it . but few above conflicts i am unable to resolve. what to do??

@ritankarsaha
Copy link
Collaborator

@ritankarsaha @harshiill i had raised PR . kindly check it . but few above conflicts i am unable to resolve. what to do??

@harshiill pls help @parthdude07 out in resolving the conflicts

  • you have deleted the env sample file to begin with pls restore that back.

@ritankarsaha
Copy link
Collaborator

@parthdude07 pls don't make separate prs for every change you make. This is like the 3rd PR you have made ig, idk i lost count atp. Try to, i mean learn to keep things under 1 PR, until and unless it's like hayshit crazy and very difficult and you need to close that PR and open another one. also pls ask me or @harshiill before you do so. also pls close redundant and old prs, very difficult to review like this and very confusing. this is callous work tbh. and i have been telling u this for the 3rd time now.🫠 Making the same mistake thrice is not progress.

P.S. - not scolding you here or calling you out, prepping u up for open source in bigger more complex repos. you can't go around in a repo and open multiple prs for a issue just because the maintainer asked you to make some changes there or reviewd it, further more you can't keep multiple prs open that too when either of the maintainers has not been communicated properly. remember to keep your work clean, and not give the maintainers a hard time. that really pisses people off.

For now, TRY TO FIX CONFLICTS IN THIS PR ITSELF AND NOT OPEN UP ANOTHER PR. Try on your own first, if you face problems @harshiill will help you out.

@parthdude07
Copy link
Author

@parthdude07 pls don't make separate prs for every change you make. This is like the 3rd PR you have made ig, idk i lost count atp. Try to, i mean learn to keep things under 1 PR, until and unless it's like hayshit crazy and very difficult and you need to close that PR and open another one. also pls ask me or @harshiill before you do so. also pls close redundant and old prs, very difficult to review like this and very confusing. this is callous work tbh. and i have been telling u this for the 3rd time now.🫠 Making the same mistake thrice is not progress.

P.S. - not scolding you here or calling you out, prepping u up for open source in bigger more complex repos. you can't go around in a repo and open multiple prs for a issue just because the maintainer asked you to make some changes there or reviewd it, further more you can't keep multiple prs open that too when either of the maintainers has not been communicated properly. remember to keep your work clean, and not give the maintainers a hard time. that really pisses people off.

For now, TRY TO FIX CONFLICTS IN THIS PR ITSELF AND NOT OPEN UP ANOTHER PR. Try on your own first, if you face problems @harshiill will help you out.

@ritankarsaha
Thanks for the detailed feedback — I completely understand now. Really sorry for creating multiple PRs and for not communicating properly before doing so. That was my mistake, and I realize how it makes the review process more confusing and frustrating.

I’ll make sure to:

  • Stick to a single PR for a given issue unless absolutely necessary.

  • Fix conflicts within the same PR instead of opening new ones.

Appreciate you pointing this out patiently and helping me understand how things are handled in larger open-source repos. I’ll be more mindful going forward 🙌

@parthdude07
Copy link
Author

@ritankarsaha @harshiill I’ve resolved all the merge conflicts in this PR. Would be great if you could review the updated code. Let me know if any changes are needed — else, feel free to merge it when convenient 🙌

@ritankarsaha
Copy link
Collaborator

@parthdude07 push your package.json and package-lock.json files as well, ig u have used new packages right ?

@ritankarsaha
Copy link
Collaborator

@parthdude07 why did u merge branch into main. ? You basically rewrote your entire commit history

@ritankarsaha
Copy link
Collaborator

ritankarsaha commented Jul 8, 2025

@parthdude07 pls don't make separate prs for every change you make. This is like the 3rd PR you have made ig, idk i lost count atp. Try to, i mean learn to keep things under 1 PR, until and unless it's like hayshit crazy and very difficult and you need to close that PR and open another one. also pls ask me or @harshiill before you do so. also pls close redundant and old prs, very difficult to review like this and very confusing. this is callous work tbh. and i have been telling u this for the 3rd time now.🫠 Making the same mistake thrice is not progress.
P.S. - not scolding you here or calling you out, prepping u up for open source in bigger more complex repos. you can't go around in a repo and open multiple prs for a issue just because the maintainer asked you to make some changes there or reviewd it, further more you can't keep multiple prs open that too when either of the maintainers has not been communicated properly. remember to keep your work clean, and not give the maintainers a hard time. that really pisses people off.
For now, TRY TO FIX CONFLICTS IN THIS PR ITSELF AND NOT OPEN UP ANOTHER PR. Try on your own first, if you face problems @harshiill will help you out.

@ritankarsaha Thanks for the detailed feedback — I completely understand now. Really sorry for creating multiple PRs and for not communicating properly before doing so. That was my mistake, and I realize how it makes the review process more confusing and frustrating.

I’ll make sure to:

  • Stick to a single PR for a given issue unless absolutely necessary.
  • Fix conflicts within the same PR instead of opening new ones.

Appreciate you pointing this out patiently and helping me understand how things are handled in larger open-source repos. I’ll be more mindful going forward 🙌

umm yep @parthdude07 , but u kinda made the same mistake again in the linting. nvm leave that 🙂 pls push the json files so that the build atleast passes.

@parthdude07
Copy link
Author

@ritankarsaha i have pushed json files.

@parthdude07
Copy link
Author

@ritankarsaha why it failed now??

@ritankarsaha
Copy link
Collaborator

umm did u push @parthdude07, it can't find tailwind dependancy. https://github.com/bsoc-bitbyte/Exam-Bud/actions/runs/16164026307/job/45723680612?pr=35

@ritankarsaha
Copy link
Collaborator

@harshiill pls review this PR.

@parthdude07, @harshiill will be reviewing your work

Copy link
Collaborator

@harshiill harshiill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritankarsaha good to go!
@parthdude07 nice work Parth

@parthdude07
Copy link
Author

umm did u push @parthdude07, it can't find tailwind dependancy. https://github.com/bsoc-bitbyte/Exam-Bud/actions/runs/16164026307/job/45723680612?pr=35

@harshiill what i can do to solve this issue?? it will be better to clarify by yourselves before taking any action.🙂

@parthdude07
Copy link
Author

@harshiill i had solved merger conflicts . kindly verify

@parthdude07
Copy link
Author

@ritankarsaha @harshiill kindly check this PR

@ritankarsaha
Copy link
Collaborator

ritankarsaha commented Jul 19, 2025

i will cry now , a single check didn't pass omg

@parthdude07
Copy link
Author

i will cry now , a single check didn't pass omg

but why?? 🥲

@ritankarsaha
Copy link
Collaborator

umm did u push @parthdude07, it can't find tailwind dependancy. https://github.com/bsoc-bitbyte/Exam-Bud/actions/runs/16164026307/job/45723680612?pr=35

@harshiill what i can do to solve this issue?? it will be better to clarify by yourselves before taking any action.🙂

wdym ? clarifying by yourselves?

@ritankarsaha
Copy link
Collaborator

ritankarsaha commented Jul 19, 2025

i will cry now , a single check didn't pass omg

but why?? 🥲

for starters what about the linting?
i have been saying u across 3 prs to fix linting errors

PLS TRY TO INCORPORATE SUGGESTIONS.

@ritankarsaha
Copy link
Collaborator

push your changed package.json files as well pls

@parthdude07 parthdude07 changed the title fix : Course list UI issue#13 feat : Course list UI issue#13 Jul 19, 2025
@ritankarsaha
Copy link
Collaborator

did u just fix the title? @parthdude07

@parthdude07
Copy link
Author

@ritankarsaha @harshiill
Most of the linting issues were due to code previously pulled into the project.
I’ve fixed them manually to ensure code consistency and pass lint checks.
Also noticed that my local version of react-router-dom was ^7.6.2, while the package.json had ^7.6.0 — i pushed exact package.json file now.

@ritankarsaha
Copy link
Collaborator

ritankarsaha commented Jul 22, 2025

@ritankarsaha @harshiill

Most of the linting issues were due to code previously pulled into the project.

I’ve fixed them manually to ensure code consistency and pass lint checks.

Also noticed that my local version of react-router-dom was ^7.6.2, while the package.json had ^7.6.0 — i pushed exact package.json file now.

Wdym by linting errors being pulled into the project or present in the earlier codebase
Linting error is made by YOU when YOU MAKE A BAD COMMIT MESSAGE which you apparently have been making for the last 19 commits across 4 PRs now.
A general step towards open source is to READ THE CONTRIBUTING.MD BEFORE CONTRIBUTING or at least take heed of what the maintainer is wanting you to do and not acting reluctantly and not making the same mistake across 19 commits and 4 prs for 1 issue.

@parthdude07

@ritankarsaha
Copy link
Collaborator

@PixelKnightDev i am assigning this PR and issue to you. Look into this pls.
I will be assigning it you tomorrow. Pls fix the mess, and make a clean PR with a proper commit message and we can close all the stale ones.

@harshiill do u have someone else in mind? As bsoc is near end , i think @PixelKnightDev would be the best to shoot up something in a short period, eager to get this fix in before bsoc ends for next yr so that can continue the work from there.

@PixelKnightDev
Copy link
Contributor

PixelKnightDev commented Jul 22, 2025

@PixelKnightDev i am assigning this PR and issue to you. Look into this pls.
I will be assigning it you tomorrow. Pls fix the mess, and make a clean PR with a proper commit message and we can close all the stale ones.

@harshiill do u have someone else in mind? As bsoc is near end , i think @PixelKnightDev would be the best to shoot up something in a short period, eager to get this fix in before bsoc ends for next yr so that can continue the work from there.

I'm open to working on it

@ritankarsaha
Copy link
Collaborator

@PixelKnightDev i am assigning this PR and issue to you. Look into this pls.
I will be assigning it you tomorrow. Pls fix the mess, and make a clean PR with a proper commit message and we can close all the stale ones.

@harshiill do u have someone else in mind? As bsoc is near end , i think @PixelKnightDev would be the best to shoot up something in a short period, eager to get this fix in before bsoc ends for next yr so that can continue the work from there.

I'm open to working on it

Cool pls do.
Will assign tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Implement Course Listing Page UI

4 participants