-
Notifications
You must be signed in to change notification settings - Fork 34
feat : Course list UI issue#13 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@ritankarsaha how i solve this |
|
@ritankarsaha @harshiill i had raised PR . kindly check it . but few above conflicts i am unable to resolve. what to do?? |
@harshiill pls help @parthdude07 out in resolving the conflicts
|
|
@parthdude07 pls don't make separate prs for every change you make. This is like the 3rd PR you have made ig, idk i lost count atp. Try to, i mean learn to keep things under 1 PR, until and unless it's like hayshit crazy and very difficult and you need to close that PR and open another one. also pls ask me or @harshiill before you do so. also pls close redundant and old prs, very difficult to review like this and very confusing. this is callous work tbh. and i have been telling u this for the 3rd time now.🫠 Making the same mistake thrice is not progress. P.S. - not scolding you here or calling you out, prepping u up for open source in bigger more complex repos. you can't go around in a repo and open multiple prs for a issue just because the maintainer asked you to make some changes there or reviewd it, further more you can't keep multiple prs open that too when either of the maintainers has not been communicated properly. remember to keep your work clean, and not give the maintainers a hard time. that really pisses people off. For now, TRY TO FIX CONFLICTS IN THIS PR ITSELF AND NOT OPEN UP ANOTHER PR. Try on your own first, if you face problems @harshiill will help you out. |
@ritankarsaha I’ll make sure to:
Appreciate you pointing this out patiently and helping me understand how things are handled in larger open-source repos. I’ll be more mindful going forward 🙌 |
|
@ritankarsaha @harshiill I’ve resolved all the merge conflicts in this PR. Would be great if you could review the updated code. Let me know if any changes are needed — else, feel free to merge it when convenient 🙌 |
|
@parthdude07 push your package.json and package-lock.json files as well, ig u have used new packages right ? |
|
@parthdude07 why did u merge branch into main. ? You basically rewrote your entire commit history |
umm yep @parthdude07 , but u kinda made the same mistake again in the linting. nvm leave that 🙂 pls push the json files so that the build atleast passes. |
|
@ritankarsaha i have pushed json files. |
|
@ritankarsaha why it failed now?? |
|
umm did u push @parthdude07, it can't find tailwind dependancy. https://github.com/bsoc-bitbyte/Exam-Bud/actions/runs/16164026307/job/45723680612?pr=35 |
|
@harshiill pls review this PR. @parthdude07, @harshiill will be reviewing your work |
harshiill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritankarsaha good to go!
@parthdude07 nice work Parth
@harshiill what i can do to solve this issue?? it will be better to clarify by yourselves before taking any action.🙂 |
|
@harshiill i had solved merger conflicts . kindly verify |
|
@ritankarsaha @harshiill kindly check this PR |
|
i will cry now , a single check didn't pass omg |
but why?? 🥲 |
wdym ? clarifying by yourselves? |
for starters what about the linting? PLS TRY TO INCORPORATE SUGGESTIONS. |
|
push your changed package.json files as well pls |
|
did u just fix the title? @parthdude07 |
6b84ee3 to
1f314cd
Compare
|
@ritankarsaha @harshiill |
Wdym by linting errors being pulled into the project or present in the earlier codebase |
|
@PixelKnightDev i am assigning this PR and issue to you. Look into this pls. @harshiill do u have someone else in mind? As bsoc is near end , i think @PixelKnightDev would be the best to shoot up something in a short period, eager to get this fix in before bsoc ends for next yr so that can continue the work from there. |
I'm open to working on it |
Cool pls do. |
Overview
This PR implements the course listing UI as part of the Exambud project. It introduces a responsive layout to display available courses, aligned with the design goals of issue [Frontend] Implement Course Listing Page UI #13. The goal is to provide users with a clean and intuitive interface for browsing course content.
✅ Designed and implemented the course listing UI based on Figma designs (with matching PNGs).
🔍 Added search functionality to each relevant component.
🛠️ Implemented error handling using try-catch and conditional rendering to prevent runtime errors.
🔄 Ensured all components are resilient and error-free, improving the overall robustness of the app.
These changes ensure the interface is clean, responsive, user-friendly, and reliable under various conditions.
Essential Checklist
Proof that changes are correct
Screen.Recording.2025-06-27.144708.1.mp4
PR Pointers