Skip to content

Max cov example#7

Merged
brunompacheco merged 8 commits intomainfrom
max-cov-example
Sep 16, 2025
Merged

Max cov example#7
brunompacheco merged 8 commits intomainfrom
max-cov-example

Conversation

@brunompacheco
Copy link
Owner

Implement the selfish EBMC games, described in https://optimization-online.org/?p=30871. Uses also instances generated by the authors from https://github.com/HyunwooLee0429/Best-response-dynamics-IPG

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.84%. Comparing base (f7c1265) to head (e63da71).

Files with missing lines Patch % Lines
src/SGM/PolymatrixGame/Polymatrix.jl 50.00% 2 Missing ⚠️
src/Game/Player.jl 94.11% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   90.31%   89.84%   -0.47%     
==========================================
  Files          13       13              
  Lines         320      325       +5     
==========================================
+ Hits          289      292       +3     
- Misses         31       33       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brunompacheco brunompacheco marked this pull request as ready for review September 16, 2025 20:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements selfish EBMC (Edge-Based Maximum Coverage) games as described in an optimization paper, using instances generated from a specific GitHub repository. The implementation adds support for bilateral payoff computation with affine expressions and includes a comprehensive example that models a lake infestation management game across multiple counties.

  • Adds method for computing bilateral payoffs with affine expressions
  • Refactors expression internalization logic into a reusable function
  • Implements a complete max coverage game example with CSV data loading and Python pickle integration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/SGM/PolymatrixGame/Polymatrix.jl Adds affine expression support and early return optimization for bilateral payoff computation
src/Game/Player.jl Extracts expression internalization into a separate reusable function
examples/max-cov.jl Implements the complete EBMC game example with data loading and game setup
examples/Project.toml Adds CSV and PyCall dependencies for the new example

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@brunompacheco brunompacheco merged commit 5a53af9 into main Sep 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants