use dispatch-based selectors for customizable parts of SGM#5
Closed
brunompacheco wants to merge 1 commit intomainfrom
Closed
use dispatch-based selectors for customizable parts of SGM#5brunompacheco wants to merge 1 commit intomainfrom
brunompacheco wants to merge 1 commit intomainfrom
Conversation
Owner
Author
|
I just realized this would make the customization more convoluted for the user that wants to use custom methods inside the SGM algorithm. For example, in the current approach, the user could simply do function get_player_random_order(players::Vector{Player}, iter::Integer, Σ_S::Vector{Profile{DiscreteMixedStrategy}}, payoff_improvements::Vector{Tuple{Player,Float64}})
return shuffle(keys(players))
end
IPG.get_player_order = get_player_random_orderThis would become significantly more complicated if the user had to handle dispatch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.