Add support to more interaction#46
Open
alessio-vivaldelli wants to merge 3 commits intobrunomnsilva:masterfrom
Open
Add support to more interaction#46alessio-vivaldelli wants to merge 3 commits intobrunomnsilva:masterfrom
alessio-vivaldelli wants to merge 3 commits intobrunomnsilva:masterfrom
Conversation
Owner
|
@alessio-vivaldelli Sorry for the late reply. In the following days i'll have a look into merging your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This PR introduces one enhancements based on my experience using the library for a university project.
Specifically, I've added new handlers for single-click and right-click events on vertices, edges, and the canvas itself:
setVertexSingleClickActionsetVertexRightClickActionsetEdgeSingleClickActionsetEdgeRightClickActionsetCanvasSingleClickActionI implemented this feature following the existing pattern you established for the double-click handlers to maintain consistency within the codebase.
Btw, if you're interested in taking a look, or perhaps even adding it to the "Projects that use this library" section of your repository, you can find the project here:
https://github.com/alessio-vivaldelli/PetriHub