-
Notifications
You must be signed in to change notification settings - Fork 41
feat(browser): add site memory for persistent cross-session knowledge #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shubh24
wants to merge
1
commit into
main
Choose a base branch
from
feat/browser-site-memory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memory feature uses CSS selectors with ref-only click command
High Severity
The memory feature's core optimization — caching CSS selectors and using them directly to skip snapshots — is built on the assumption that
browse clickaccepts CSS selectors. However, per the REFERENCE.md and every example in EXAMPLES.md,browse clickonly accepts snapshot refs (e.g.,@0-5), not CSS selectors. The examplebrowse click ".titleline > a"will fail. The memory system instructs recording "stable selectors" likeinput[name="email"]and[data-testid="..."], but these cannot be used with the primary interaction command.Additional Locations (2)
skills/browser/SKILL.md#L153-L154skills/browser/SKILL.md#L102-L103Reviewed by Cursor Bugbot for commit efee8bf. Configure here.