Improve errors for csv-table-file and csv-table-url
#1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terns for url or non-url
dbp
force-pushed
the
csv-table-foo-errors
branch
from
04c5357 to
23f7f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not actually sure how to test this, since my local testing strategy for stuff like this would usually use the local CPO, but CSVs are not usable through CPO.
But, it's also a pretty minimal (and perhaps, not that great?) change.
Either way, it would be good to have some improvement for #1803 before students start trying to use the
csvstuff -- people bumped into this issue really quickly.