horizon -> master #1787
Open
horizon -> master #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Modifier as a record type for future-proofing (e.g. when CapsLock as a modifier is actually standardized across browsers) Provide three versions of the pressed key: - symbol: The thing you'd want to insert into a text editor (e.g. if I press alt+5 on my Macbook, this is the string "∞"). This still includes things you _wouldn't_ want to insert, like "ArrowUp", so filtering would be required for a text editor, but once modifier presses are filtered out, the _symbol_ is correct. Computed from `e.key` in JS - code: The numeric keycode of the physical key pressed. This is independent of modifiers. Striking the key that physically has j printed on it on my Macbook will always produce 74, no matter what else I hold down. Computed from `e.charCode || e.keyCode` in JS. - key: The same processed string that's given to keypress. This is mainly to ease porting of game code from keypress to raw-key, so that the same string is readily available. Computed from the same `getKeyCodeName` helper in the world library as the keypress event uses
There were some interesting un-reported conflicts that were resolved in desugar-post-tc and in post-load-hooks, so the diffs for those are relevant. In addition, this commit MAY have a stale environment setting for "within" that causes it to not be intepreted as flat.
… to the standalone
Improve Reproducibility
OK, this is super weird. I'm not sure how this was working before, but it certainly was, unless somehow node-canvas behaves differently in webviews than in real browser tabs. Also I'm not sure how new-image-things ever passed on Travis. But it sure seems like node-canvas does not in fact provide an Image constructor when run in-browser -- canvas.Image is clearly undefined and only the default browser canvas APIs are there when we import it this way. So, we have to do the polyfill bit ourselves and make sure `Image` is correctly set up as the nonstandard canvas.Image from node-canvas when offline and to the browser's window.Image in browsers
…to opts. fix cli text-based render-reason
…ig-headers To avoid potential clashes with different clients, it's better if the new spec for these tuples is that the new field is at the end, and to allow the old or new length. Also pragmatically this avoids coming up with a good answer for gdrive-sheets while still enjoying this runtime change for CSV loading.
Dbp table mismatch
I've added a new method to scatter- and line-plots (which support image-labels), `.use-image-sizes(use-size :: Boolean)`, to toggle whether the charts should show the images at full size (true) or scaled to the point-size (false)
analogous to image-scatter-chart, this places custom images instead of translucent dots. it is up to the caller to either scale the images down to match the point-size, or set the point-size up to match the image size
The origin for the line should be at x1, y1, but since the arguments to makeOverlayImage move the _background_ right and down, we need to reverse both. This will mean that the background goes left and up and the start of the line is at the right place.
As it turns out, if your line is in the "wrong direction", the previous code didn't work. You have to shift by the closest point to the origin.
Fix add-line overlay
note: we do not support spacing of grid lines, or minor gridlines
…dot plots" that used to be a post-processing hackaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.