Skip to content

Conversation

@bistline
Copy link
Contributor

BACKGROUND & CHANGES

This update fixes several bugs with the search options button:

  • Entries could not be selected by clicking the label
  • Entries did not use the cursor pointer when hovering
  • Clicking outside the widget did not dismiss it

These were all addressed by using the useCloseableModal hook to make this control behave exactly as other search facets do. Additionally, a "Clear" button has been added to remove all selected search options without clearing any terms/facets.

MANUAL TESTING

  1. Boot as normal and run any faceted or text search
  2. Open the options facet and confirm the entries behave as stated above
  3. Click the "Clear" button with one or more selections checked and confirm the menu closes & search updates without removing any terms/facets

@bistline bistline requested a review from eweitz October 14, 2025 16:36
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.55%. Comparing base (022394a) to head (ac49d23).
⚠️ Report is 8 commits behind head on development.

Files with missing lines Patch % Lines
...cript/components/search/controls/OptionsButton.jsx 65.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2312      +/-   ##
===============================================
- Coverage        71.61%   71.55%   -0.06%     
===============================================
  Files              339      339              
  Lines            29090    29102      +12     
  Branches          2648     2651       +3     
===============================================
- Hits             20832    20824       -8     
- Misses            8117     8137      +20     
  Partials           141      141              
Files with missing lines Coverage Δ
...ript/components/search/controls/OptionsControl.jsx 100.00% <100.00%> (ø)
...cript/components/search/controls/OptionsButton.jsx 72.00% <65.00%> (-28.00%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bistline
Copy link
Contributor Author

Build failures are tracked in SCP-6059 and are unrelated to this change.

@eweitz
Copy link
Member

eweitz commented Oct 15, 2025

The build failure looks like a false positive.

Total elapsed time: 28 minutes, 3 seconds

### FAILURES and ERRORS ###
*** Yarn test failures ***
  FAIL test/js/upload-wizard/upload-new-study.test.js (23.253 s)
      ✕ allows upload of all common file types in sequence (11087 ms)
  FAIL test/js/upload-wizard/upload-new-study.test.js (23.253 s)

*** Rails test failures ***

  BulkDownloadControllerTest#test_should_return_preview_of_bulk_download_files_and_total_bytes [test/api/bulk_download_controller_test.rb:126]:
  Expected response to be a <2XX: success>, but was a <500: Internal Server Error>

  AzulSearchServiceTest#test_should_get_summary_file_information_from_project_shortnames:
  RestClient::BadRequest: 400 Bad Request Bad Request

  HcaAzulClientTest#test_should_get_all_projects_without_error:
  RestClient::BadRequest: 400 Bad Request Bad Request
Exiting with code: 1
Error: Process completed with exit code 1.

Copy link
Member

@eweitz eweitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good robustness fixes!

@bistline bistline merged commit e1689da into development Oct 15, 2025
5 of 6 checks passed
@github-actions github-actions bot deleted the jb-search-option-ux branch October 15, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants