Update annotate_downsampling to work without gen_anc_expr #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-w-wilson
approved these changes
Aug 22, 2025
Contributor
mike-w-wilson
left a comment
mike-w-wilson
left a comment
There was a problem hiding this comment.
A minor comment but otherwise looks good -- thanks for fixing and adding the tests!
gnomad/utils/annotations.py
Outdated
| return t.annotate_globals( | ||
| downsamplings=downsamplings, | ||
| ds_gen_anc_counts=gen_anc_counts, | ||
| ) |
Contributor
There was a problem hiding this comment.
This is strictly personal preference and obviously makes no difference in what happens but if something exists in both the if and else which is essentially what this is, I typically move it out just for maintainability/readability. This one is super minor but also results in less diff. Feel free to ignore if you like the other way
Co-authored-by: Mike Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code within
annotate_downsamplingsfails ifgen_anc_exprisn't specified, despite this being an optional argument.This PR fixes this issue and also adds tests for this function