Eliminate stochasticity in Median Coverage calculation #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is useful but let's hold off on this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intended to eliminate stochasticity in the
MedianCovworkflow by including a default seed of 42 when randomly subsampling, which occurs in two places:covPerSample(), we downsample to 1M bins if the input matrix has more bins than this.covPerBin(), we downsampling to 500 samples if there are many samples for a given bin.Testing
EvidenceQc, a workflow which calls uponMedianCov.bincov_medianoutput file is identical, despite there being over 29M bins in the input file.NA20320sample has often switched between a coverage value of 19 and 20.womtool.