This repository was archived by the owner on Mar 23, 2023. It is now read-only.
#183 Fix "Connection refused" with docker-machine#184
Open
rkuzsma wants to merge 1 commit into
Open
Conversation
Fix for "Connection refused" running docker-osx-dev with docker-machine #183
| # Support < 0.4.1 and >= 0.5.1 | ||
| DOCKER_HOST_USER=$(inspect_docker_machine "{{.Driver.SSHUser}}" || inspect_docker_machine "{{.Driver.Driver.SSHUser}}") | ||
| DOCKER_HOST_IP=$(inspect_docker_machine "{{.Driver.IPAddress}}" || inspect_docker_machine "{{.Driver.Driver.IPAddress}}") | ||
| DOCKER_HOST_IP=$(docker-machine ip) |
Owner
There was a problem hiding this comment.
The ip command takes the machine name as an arg. Shouldn't you use $DOCKER_MACHINE_NAME as a parameter here?
There was a problem hiding this comment.
It fallbacks to "default" if none is give: https://github.com/docker/machine/blob/5b9663f8960af73c048e14cc60566ae487c07728/commands/commands.go#L102 but to me it seems that it would be best to supply the $DOCKER_MACHINE_NAME in here so this would work for people using a different machine name :) So $(docker-machine ip "$DOCKER_MACHINE")
Owner
|
Thanks for the PR. Just one comment. If you make a change, make sure to post a comment, as GitHub doesn't send notifications for new code pushes to a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for "Connection refused" running docker-osx-dev with docker-machine
#183