Fix: Cast loop variable to ImU32 in ImPlot3DColormapData to fix C4365 warning#176
Merged
brenocq merged 1 commit intobrenocq:mainfrom Feb 20, 2026
Conversation
brenocq
approved these changes
Feb 20, 2026
Owner
brenocq
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix @JunkyoLee!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build error
In implot3d_internal.h line 266, the for-loop counter s is declared as int but is passed directly to ImMixU32(ImU32, ImU32, ImU32), causing a C4365 signed/unsigned mismatch warning on MSVC. When warnings are treated as errors (e.g. /W4 /WX builds), this breaks compilation.
Fix (applied): Cast s to ImU32
Instead of suppressing this warning, I addressed the root cause in the code to ensure a more robust solution.
Alternative considered: Changing the loop variable itself to ImU32: