Open
Conversation
Owner
|
Hi @juanmanzanero! That's a lot of features hahahha thank you for pouring so much time into ImPlot3D I suggest you to create 6 feature requests issues (one for each feature that you implemented), and create one separate PR for each feature. Each feature PR should also contain a demo for the new feature (this helps me test the PR, and quite nice for people exploring the ImPlot3D demos to see your feature in action). I probably need to document a bit better the feature contribution process kkkkk |
Owner
|
Oh, I think this needs to change: -IMPLOT3D_API void Annotation(double x, double y, double z, const ImVec4& col, const ImVec2& pix_offset, bool clamp, const char* fmt, ...) IM_FMTARGS(6);
-IMPLOT3D_API void AnnotationV(double x, double y, double z, const ImVec4& col, const ImVec2& pix_offset, bool clamp, const char* fmt, va_list args) IM_FMTLIST(6);
+IMPLOT3D_API void Annotation(double x, double y, double z, const ImVec4& col, const ImVec2& pix_offset, bool clamp, const char* fmt, ...) IM_FMTARGS(7);
+IMPLOT3D_API void AnnotationV(double x, double y, double z, const ImVec4& col, const ImVec2& pix_offset, bool clamp, const char* fmt, va_list args) IM_FMTLIST(7); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @brenocq
Thank you for this very nice plotting library. I'd like to contribute with some features that me and others might benefit from:
To implement these I had to:
And also:
Thank you for your time.