Add brotli extension support #547
Open
+57
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this was an intentional decision by AWS since the compute requirements for compression are very high, an order of magnitude more than for gzip, and the average compression ratio is barely better. |
|
They support payload compression on REST API but not in HTTP API (yet). I think it should be okay to give users the option to handle the compression themselves. |
Nyholm
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Brotli support.
Since neither AWS HTTP API Gateway nor CloudFront has the ability to compress responses with Brotli, we can achieve this by using something like https://github.com/open-southeners/laravel-vapor-response-compression