Improve mobile link flow - #117
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: brandonpham13 <29783274+brandonpham13@users.noreply.github.com>
Contributor
Resolved and committed the merge conflicts in this PR in commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the user experience for connecting Sleeper accounts by deep-linking users directly to the integrations panel, both in the UI and in the documentation. It introduces a new two-mode
AccountModal, updates the Sidebar and Create Huddle flows to use the direct integration shortcut, and clarifies best practices and data ownership in the playbook.User Experience Improvements:
AccountModalthat can open either the full Clerk profile or directly to the integrations panel via the newAccountModalTabtype, making it much easier for users (especially on mobile) to connect their Sleeper account. (client/src/components/AccountModal.tsx) [1] [2] [3] [4] [5] [6]client/src/components/Sidebar.tsx) [1] [2] [3] [4] [5] [6]client/src/components/huddles/CreateHuddleModal.tsx) [1] [2] [3]Documentation and Best Practices:
PLAYBOOK.md)Internal Consistency and Type Safety:
AccountModalTabtype for improved type safety and maintainability. (client/src/components/AccountModal.tsx,client/src/components/Sidebar.tsx) [1] [2] [3]These changes make connecting a Sleeper account much more intuitive, especially on mobile, and establish clear conventions for future development and documentation.