Skip to content

Conversation

Fasosnql
Copy link
Collaborator

@Fasosnql Fasosnql commented Nov 6, 2024

Description

Specified missing dependencies in dependecies list of the packages. Those packages cannot work without those deps so it should be installed together with package, not via peer dependency or at all.

Additionally fixed brainly-gene init script to install everything what needed to make workspace work.

I commented out eslint plugin replacement because gene one doesn't work so far and throws errors:

1:1  error  Definition for rule '@brainly-gene/eslint-plugin/use-listener' was not found  @brainly-gene/eslint-plugin/use-listener

it should be fixed as part of the separate PR. Once it will be fixed those lines could be uncommented

@Fasosnql Fasosnql requested review from kopach and krzotki November 6, 2024 10:43
@Fasosnql Fasosnql added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 6, 2024
@Fasosnql Fasosnql enabled auto-merge November 6, 2024 16:38
@Fasosnql Fasosnql added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 6, 2024
@kopach kopach merged commit 41b8357 into master Nov 7, 2024
15 checks passed
@kopach kopach deleted the fix/add-missing-dependencies-in-packages branch November 7, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants