Skip to content

fix: add missing dependency for create-gene-workspace #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2024
Merged

fix: add missing dependency for create-gene-workspace #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dde5af
fix: add missing dependency for create-gene-workspace
kopach Nov 8, 2024
9466b9a
chore: 🔖 bump monorepo to v0.1.3-rc.3
kopach Nov 8, 2024
18a19b7
Merge remote-tracking branch 'origin/master' into release/v0.1.3-rc.3
krzotki Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "0.1.3-rc.2",
"version": "0.1.3-rc.3",
"license": "Apache-2.0",
"scripts": {
"generate-package": "nx generate library --publishable --buildable",
Expand Down
2 changes: 2 additions & 0 deletions packages/create/bin/create-gene-workspace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ async function runCommands() {
'brainly-style-guide',
`[email protected]`,
`@tanstack/[email protected]`,
'@nrwl/[email protected]',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is also dev dep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fasosnql , we use it during runtime, in next.config.js

gene/packages/gene-tools/src/generators/bff-app-generator/files/app/next.config.js__tmpl__

Line 1 in 9466b9a

const withNx = require('@nrwl/next/plugins/with-nx');

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's correct way of using it, btw https://nx.dev/recipes/next/next-config-setup#composing-plugins-using-composeplugins-utility-nx-16-and-later

]);

// Install dev dependencies
Expand All @@ -114,6 +115,7 @@ async function runCommands() {
'[email protected]',
'[email protected]',
'[email protected]',
'@nrwl/[email protected]',
]);

console.log('Generating gene-workspace with pnpm nx');
Expand Down
2 changes: 1 addition & 1 deletion packages/create/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@brainly-gene/create",
"version": "0.1.3-rc.2",
"version": "0.1.3-rc.3",
"type": "commonjs",
"bin": {
"create-gene-workspace": "./bin/create-gene-workspace.js"
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@brainly-gene/eslint-plugin",
"version": "0.1.3-rc.2",
"version": "0.1.3-rc.3",
"license": "Apache-2.0",
"main": "src/index.js",
"generators": "./generators.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/gene-apollo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@brainly-gene/apollo",
"version": "0.1.3-rc.2",
"version": "0.1.3-rc.3",
"license": "Apache-2.0"
}
2 changes: 1 addition & 1 deletion packages/gene-next/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@brainly-gene/next",
"version": "0.1.3-rc.2",
"version": "0.1.3-rc.3",
"license": "Apache-2.0",
"dependencies": {
"@next/bundle-analyzer": "12.3.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/gene-sentry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@brainly-gene/sentry",
"version": "0.1.3-rc.2",
"version": "0.1.3-rc.3",
"license": "Apache-2.0"
}
2 changes: 1 addition & 1 deletion packages/gene-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@brainly-gene/tools",
"version": "0.1.3-rc.2",
"version": "0.1.3-rc.3",
"license": "Apache-2.0",
"generators": "./generators.json",
"executors": "./executors.json",
Expand Down
2 changes: 1 addition & 1 deletion packages/gene/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@brainly-gene/core",
"version": "0.1.3-rc.2",
"version": "0.1.3-rc.3",
"license": "Apache-2.0",
"main": "./src/index.js",
"dependencies": {
Expand Down
Loading