fix: avoid creating duplicated convert to draft buttons#21
Conversation
Summary of ChangesHello @braineo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the 'convert to draft' button could appear multiple times or incorrectly on a merge request detail page. The changes introduce robust conditional rendering, ensuring the button is only present when a merge request is not yet a draft and is automatically removed if the merge request's title indicates it's already a draft. This improves the user experience by providing a cleaner and more accurate interface. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the issue of duplicate 'Convert to draft' buttons being created on the merge request detail page. The approach of adding a unique ID to the button and checking for its existence before creation is solid. Additionally, the logic is enhanced to remove the button if the merge request is already a draft, which improves the user experience. The use of a getTitle helper function to fetch the latest title within the event handler is also a good improvement. I've found one minor issue with a redundant line of code that can be removed.
No description provided.