Skip to content

fix: avoid creating duplicated convert to draft buttons#21

Merged
braineo merged 2 commits intomasterfrom
fix-duplicate-button
Nov 19, 2025
Merged

fix: avoid creating duplicated convert to draft buttons#21
braineo merged 2 commits intomasterfrom
fix-duplicate-button

Conversation

@braineo
Copy link
Copy Markdown
Owner

@braineo braineo commented Nov 19, 2025

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @braineo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the 'convert to draft' button could appear multiple times or incorrectly on a merge request detail page. The changes introduce robust conditional rendering, ensuring the button is only present when a merge request is not yet a draft and is automatically removed if the merge request's title indicates it's already a draft. This improves the user experience by providing a cleaner and more accurate interface.

Highlights

  • Preventing Duplicate Buttons: Implemented logic to prevent the 'convert to draft' button from being duplicated on merge request detail pages, ensuring it appears only when necessary.
  • Dynamic Button Management: The button is now dynamically added if the merge request is not a draft and removed if it is already a draft, improving UI consistency.
  • Code Refactoring: The logic for retrieving the merge request title has been encapsulated into a reusable getTitle function.
  • Button Identification: An id attribute (#convert-to-draft-button) has been added to the dynamically created button for easier DOM manipulation and identification.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses the issue of duplicate 'Convert to draft' buttons being created on the merge request detail page. The approach of adding a unique ID to the button and checking for its existence before creation is solid. Additionally, the logic is enhanced to remove the button if the merge request is already a draft, which improves the user experience. The use of a getTitle helper function to fetch the latest title within the event handler is also a good improvement. I've found one minor issue with a redundant line of code that can be removed.

@braineo braineo merged commit f05acd1 into master Nov 19, 2025
6 checks passed
@braineo braineo self-assigned this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant