Skip to content

Fix rust CI builds in untagged checkouts - #1

Draft
joschaschmiedt with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-rust-actions-job
Draft

Fix rust CI builds in untagged checkouts#1
joschaschmiedt with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-rust-actions-job

Conversation

Copilot AI commented Aug 6, 2026

Copy link
Copy Markdown

The rust GitHub Actions job was failing before compilation because server/build.rs requires VSTIMD_VERSION, while CI branch/PR runs in this repository do not have a reachable v* tag. As a result, ordinary CI builds aborted in version resolution instead of exercising the Rust build/test pipeline.

  • CI version stamping

    • Set a workflow-wide VSTIMD_VERSION in .github/workflows/ci.yml for branch and PR runs.
    • Use a deterministic development version derived from the run number and commit SHA, so server/build.rs takes its explicit-version path instead of panicking on missing tags.
  • Release behavior remains tag-driven

    • Leave release.yml unchanged, so release artifacts still derive their version from Git tags rather than CI defaults.
  • Workflow cleanup

    • Remove repeated checkout comments in ci.yml that implied tag fetching alone was sufficient for this repository’s CI builds.

Example:

env:
  CARGO_TERM_COLOR: always
  VSTIMD_VERSION: 0.0.0+ci.${{ github.run_number }}.g${{ github.sha }}

Co-authored-by: joschaschmiedt <2520458+joschaschmiedt@users.noreply.github.com>
@joschaschmiedt

Copy link
Copy Markdown

@copilot, can we not use the last tag version plus a dev suffix with the commit hash? 0.0.0 is not very useful.

Copilot AI changed the title [WIP] Fix failing GitHub Actions job rust Fix rust CI builds in untagged checkouts Aug 6, 2026
Copilot AI requested a review from joschaschmiedt August 6, 2026 12:49
Co-authored-by: joschaschmiedt <2520458+joschaschmiedt@users.noreply.github.com>

Copilot AI commented Aug 6, 2026

Copy link
Copy Markdown
Author

@copilot, can we not use the last tag version plus a dev suffix with the commit hash? 0.0.0 is not very useful.

Addressed in 4691630. The rust workflow now uses the tag-derived version when git-version.sh can resolve one, falls back to the repository’s latest v* tag plus a CI suffix when tags exist but aren’t reachable from HEAD, and only uses 0.0.0+ci... when the repo truly has no tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants