Skip to content

Conversation

@bfoxx1906
Copy link
Contributor

@bfoxx1906 bfoxx1906 commented Dec 27, 2025

Updating css selectors to use bp-media-container instead of bp-media-dash as bp-media-container provides more flexibility regarding the different types of preview viewers.

Screenshot 2025-12-26 at 10 25 09 PM

@bfoxx1906 bfoxx1906 requested review from a team as code owners December 27, 2025 03:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 27, 2025

Walkthrough

DOM class selector names are updated from bp-media-dash to bp-media-container across video timestamp utilities, tests, and component stories. The change affects how video elements are queried when calculating timestamp information. No logic modifications or functional behavior changes.

Changes

Cohort / File(s) Summary
Video timestamp utilities
src/elements/content-sidebar/activity-feed/utils/formatTaggedMessage.js, src/elements/content-sidebar/activity-feed/utils/__tests__/formatTaggedMessage.test.js
Updated DOM selector from .bp-media-dash to .bp-media-container in both the main utility and its test. Affects how video elements are located when handling timestamp click events; query logic and timestamp calculation remain unchanged.
Component implementations
src/components/form-elements/draft-js-mention-selector/DraftJSMentionSelector.js, src/elements/content-sidebar/activity-feed/comment-form/stories/CommentForm.stories.js
Updated DOM class selector reference from bp-media-dash to bp-media-container in getVideoTimestamp function and CommentForm story wrapper. Changes affect styling/element targeting only; no behavioral modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

ready-to-merge

Suggested reviewers

  • JChan106
  • tjuanitas
  • jfox-box

Poem

🐰 A hop through the DOM, from dash to container we go,
Class names refreshed, the video elements now know,
No logic was bent, just selectors renamed with care,
Timestamps still flow where the media lives there! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating CSS selectors from bp-media-dash to bp-media-container for timestamped comments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description clearly states the purpose of the changes (updating CSS selectors from bp-media-dash to bp-media-container for flexibility) and includes a screenshot. However, it lacks the structured template format recommended for this repository.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify bot added the queued label Dec 29, 2025
@mergify mergify bot merged commit 953b6f6 into box:master Dec 29, 2025
10 checks passed
@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2025

Merge Queue Status

✅ The pull request has been merged at b1a7707

This pull request spent 6 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge

@mergify mergify bot removed the queued label Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants