Skip to content

Conversation

@Hawra2020
Copy link
Contributor

No description provided.

@Hawra2020 Hawra2020 requested a review from a team December 10, 2025 02:42
@coveralls
Copy link
Collaborator

coveralls commented Dec 10, 2025

Pull Request Test Coverage Report for Build 20161470699

Details

  • 73 of 103 (70.87%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+11.8%) to 16.956%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/box-client.ts 64 68 94.12%
src/util/token-storage-adapter.ts 9 35 25.71%
Totals Coverage Status
Change from base Build 20101413453: 11.8%
Covered Lines: 9830
Relevant Lines: 36242

💛 - Coveralls

@mwwoda mwwoda closed this Dec 10, 2025
@Hawra2020 Hawra2020 reopened this Dec 11, 2025
Copy link
Member

@congminh1254 congminh1254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very good work 👍

@Hawra2020 Hawra2020 merged commit 320c35e into combined-sdk Dec 15, 2025
6 of 9 checks passed
@Hawra2020 Hawra2020 deleted the sdk-5416-reuse-client-settings-and-auth-in-packages branch December 15, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants