BM-2449: Pre-lock check before lock tx#1669
Merged
Conversation
…/estimate_gas_consistent
Base fulfill cost and gas per journal byte pulled from transactions on mainnet and simulations on testnet. Builds on #1612
austinabell
reviewed
Feb 19, 2026
Contributor
|
My intuition is that during pricing, you have the gas estimated that will be used, so you could just pull gas price and check profitability that way? We are * by gas price currently but could change or add another field to |
capossele
changed the title
…gas-prices-at-lock-skip
github-actions
bot
changed the title
capossele
changed the title
capossele
requested review from
a team,
Wollac,
ec2,
jonastheis,
nahoc,
unizarr,
willemolding and
zeroecco
as code owners
willpote
approved these changes
Feb 23, 2026
willpote
pushed a commit
that referenced
this pull request
Feb 25, 2026
Before sending a lock transaction, we re-check that gas cost is within the order’s current price. If not, we skip locking (and, potentially, retry later). This avoids locking when gas has spiked. --------- Co-authored-by: austinabell <austinabell8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before sending a lock transaction, we re-check that gas cost is within the order’s current price. If not, we skip locking (and, potentially, retry later). This avoids locking when gas has spiked.