Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions opapi/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bpinternal/opapi",
"version": "1.0.0",
"version": "1.0.1",
"description": "Opapi is a highly opinionated library to generate server, client and documentation from OpenAPI specification using typescript.",
"main": "./dist/index.js",
"module": "./dist/index.mjs",
Expand All @@ -17,7 +17,7 @@
},
"scripts": {
"test": "vitest run",
"build": "tsup src/index.ts --dts --format cjs,esm --clean",
"build": "tsdown",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Build Output Contract Can Drift

The old command explicitly built src/index.ts with CJS, ESM, declarations, and a clean output, but bare tsdown now relies on default discovery. If tsdown does not emit the same dist/index.js, dist/index.mjs, and dist/index.d.ts files referenced by this package, the release can build with missing or renamed artifacts and consumers will fail to resolve the package.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

"check:type": "tsc --noEmit",
"check:format": "prettier --check .",
"fix:format": "prettier --write .",
Expand All @@ -35,7 +35,7 @@
"@types/verror": "1.10.10",
"prettier": "3.4.1",
"ts-node": "10.9.2",
"tsup": "8.3.5",
"tsdown": "0.22.4",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Build Tool Requires Newer Node

The new tsdown toolchain pulls in rolldown native bindings with a Node floor of ^20.19.0 || >=22.12.0, but the package does not declare that runtime requirement. CI or local builds on older supported Node versions can install dependencies and then fail when pnpm build runs.

"typescript": "5.7.2",
"vite": "5.4.11",
"vite-node": "1.6.0",
Expand All @@ -51,7 +51,7 @@
"json-schema-to-typescript": "13.1.2",
"json-schema-to-zod": "1.1.1",
"lodash": "^4.17.21",
"openapi-typescript": "6.7.6",
"openapi-typescript": "7.13.0",
"openapi3-ts": "2.0.2",
"radash": "12.1.0",
"tsconfig-paths": "4.2.0",
Expand Down
Loading
Loading