Skip to content

install: Preserve /var when installing to existing root - #2586

Open
ckyrouac wants to merge 38 commits into
bootc-dev:mainfrom
ckyrouac:preserve-var
Open

ckyrouac wants to merge 38 commits into
bootc-dev:mainfrom
ckyrouac:preserve-var

tmt: Exclude OSTree entries from baseline BLS lookup

79113f2
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Nov 12, 2026 in 1s

Check failed

There are 27 commits incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🟢 b6b28ce install: Add tested /var migration engine Valid sign-off found
🟢 109c600 install: Separate bound-image resolution from stat... Valid sign-off found
🟢 1d905b5 install: Wire /var migration into existing-root in... Valid sign-off found
🟢 ef49df4 install: Use reflinks for /var migration when avai... Valid sign-off found
🟢 168794c docs: Explain preserve-var migration behavior Valid sign-off found
🟢 9e1a300 tmt: Test package-mode /var preservation Valid sign-off found
🟢 c778103 tmt: Install preserve-var workdir rule in deployme... Valid sign-off found
🟢 f7d04ef tests: Restore nested bind-mount preserve-var cove... Valid sign-off found
🟢 4fa58a9 lib: Harden preserve-var migration safety Valid sign-off found
🟢 0306435 docs: Clarify preserve-var crash durability Valid sign-off found
🟢 86a65e0 docs: Clarify preserve-var migration guarantees Valid sign-off found
🔴 592ad9a install: Preflight preserve-var sources before ins... Sign-off not found
🔴 6128c9d install: Merge image-seeded preserve-var mountpoin... Sign-off not found
🔴 de01e76 install: Gate preserve-var exclusions Sign-off not found
🔴 4f2e942 install: Relabel preserved /var from target policy Sign-off not found
🔴 c978fe8 tests: Expand package-mode preserve-var coverage Sign-off not found
🔴 42a594c docs: Explain preserve-var SSH host key handling Sign-off not found
🔴 27417bc install: Check hardlink labels before relabeling Sign-off not found
🔴 53af74a tests: Fix package-mode TMT workdir setup Sign-off not found
🔴 38cce56 tests: Harden preserve-var TMT workdir cleanup Sign-off not found
🔴 c5c63e2 tests: Close TMT log freeze cleanup race Sign-off not found
🔴 f858514 tests: Fix local package-mode TMT runner Sign-off not found
🔴 e3103f3 tests: Force OSTree package-mode test image Sign-off not found
🔴 8092e18 tests: Exclude temporary build secrets from TMT sn... Sign-off not found
🔴 9fdfd4e tests: Preserve pre-existing build secret files Sign-off not found
🔴 7ba91fc tests: Avoid deleting shared Podman build secrets Sign-off not found
🔴 999f586 tmt: Exercise preserve-var relabeling from disable... Sign-off not found
🔴 876b9b8 tests: Resolve package-mode TMT workdirs canonical... Sign-off not found
🔴 71cad73 tests: Create PostgreSQL test mountpoint Sign-off not found
🔴 025f6b7 tests: Set PostgreSQL test volume ownership Sign-off not found
🔴 f10048a tmt: Seed PostgreSQL below bind mount Sign-off not found
🔴 0e2fac6 tmt: Use explicit PostgreSQL seed endpoints Sign-off not found
🔴 ea7b305 tmt: Mount PostgreSQL seed at target data path Sign-off not found
🔴 abd747f tmt: Verify PostgreSQL data path in target image Sign-off not found
🔴 05ae3de tmt: Compare boot manifests around rejected prefli... Sign-off not found
🔴 bdcec68 tmt: Cover EFI fallback boot entries Sign-off not found
🔴 d620ac2 tests: Snapshot package-mode BLS entries for prefl... Sign-off not found
🔴 79113f2 tmt: Exclude OSTree entries from baseline BLS look... Sign-off not found

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.

Option 2: fix commits without sign-off

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

Warning

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~38 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin preserve-var