Skip to content

Removes handshaker in favor of asio::deferred #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Removes handshaker in favor of asio::deferred #291

wants to merge 1 commit into from

Conversation

anarthal
Copy link
Collaborator

Also fixes #290

@anarthal
Copy link
Collaborator Author

This is still early work, but the idea is getting rid of the entire handshaker class, since the same functionality can be implemented in terms of asio::deferred. I think I've found a bug (see #290) while looking at the code.

@mzimbres
Copy link
Collaborator

Much welcome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A response error to HELLO may cause subsequent handshake attempts to fail
2 participants
@anarthal @mzimbres