-
Notifications
You must be signed in to change notification settings - Fork 169
Fix clang compilation in CI #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #778 +/- ##
===========================================
- Coverage 82.34% 81.99% -0.35%
===========================================
Files 117 117
Lines 5726 5354 -372
===========================================
- Hits 4715 4390 -325
+ Misses 1011 964 -47 🚀 New features to boost your workflow:
|
|
On (clang, 14,17, macos-13) The build fails with On (clang, clang++-5.0, 14,1z, ubuntu-latest, ubuntu:18.04, clang-5.0) The build is completely broken with |
|
The first issue is a well know issue of the libc++ that ships with macos 13 and can eventually be fixed with a polyfill like https://github.com/acts-project/vecmem/pull/105/files As for the second issue, I am in favor of dropping this variant. |
|
I also think dropping that variant sounds sensible. |
|
Regarding macos 13, I have just got this This is a scheduled macos-13 brownout. The macOS-13 based runner images are being deprecated. For more details, see actions/runner-images#13046. So the effort to fix it is not worth it. |
f4aae25 to
82fb089
Compare
|
Awesome, thank you! |
Description
Two CI jobs are currently failing. Investigate if they can be fixed or if they are deprecated and can be removed.
References
posix (clang, clang++-5.0, 14,1z, ubuntu-latest, ubuntu:18.04, clang-5.0)
posix (clang, 14,17, macos-13)
Tasklist