Add background jobs to find and add missing covers #3669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds on previous work in `scheduled-delete-exports`. Adds new background jobs: * schedulable job to scan connectors for book covers for editions without them * non-schedulable job to scan connectors for book covers for editions where they have a cover filepath but it does not resolve to an actual file I also had to move `set_cover_from_url()` to utils.images because trying to use it from a model was causing circular import problems.
|
Sorry about all the commits 🙃 |
hughrun
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on previous work in
scheduled-delete-exports(#3655) – this PR includes code from that one so #3655 should be pulled first.Adds new background jobs:
I also had to move
set_cover_from_url()to utils.images because trying to use it from a model was causing circular import problems.I made some choices that others may not agree with (e.g. don't allow regular schedule for finding incorrect cover filepaths - mostly because it seems like it would take a lot of resources to check but is a niche problem). Also there's a nested series of if statements I'm not thrilled about - so I'm happy to take feedback for improving it!
What type of Pull Request is this?
Does this PR change settings or dependencies, or break something?
Details of breaking or configuration changes (if any of above checked)
Documentation
Tests