-
Notifications
You must be signed in to change notification settings - Fork 11
Expand and reformat "Commands and Shortcuts" section in "Workflow Editor" article #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@RoboDoig requested you as a reviewer because I hear you're really fast at live demos 😄 Could you check if I missed any keyboard shortcuts or if you'd like to tweak the list? |
@banchan86 This is definitely needed, thanks! I will review more carefully, but one thing that jumps to mind is having the keyboard shortcuts column to the side might make it simultaneously more confusing and less visible. I wonder if we should just have one of these tab interfaces where people can pick which modality they want to consult (keyboard or mouse) and have a separate table for each? This might also make it possible to solve more cleanly your issue with key modifiers in the mouse interface. Otherwise we can do like VS code and keep all the shortcuts in a handy PDF cheat sheet: keyboard-shortcuts-windows.pdf |
374c298
to
004ccfe
Compare
Adopted a tab layout to separate mouse controls from keyboard controls. With the separate tabs there are now some actions with no corresponding control (indicated by N/A), for the purpose of the review I have just kept them in there for now, but for the final edit we can remove them (or discuss if we want to add the shortcut/control to the editor). Also at some point we could point a reference to either this section or a pdf within the editor bonsai-rx/bonsai#2083. |
49e070b
to
61776d8
Compare
@banchan86 I have literally just learned of this, but there are recommended guidelines for referring to keyboard shortcuts in documentation. I have tested the styling of the special tags and they do work in DocFX in both light and dark themes. We may want to do a general pass through the documentation to replace all of the keyboard shortcut references to use this style as it makes the shortcuts stand out differently from code elements. To make it easier to wrap keys with the |
@glopesdev The suggested keyboard styling sounds great, thanks for finding it, and fixing up the style! I will revise this PR and will make a note to catch others that are littered throughout documentation. |
61776d8
to
b5bfc42
Compare
PR updated, I love the new style! |
Oh I just realized that with Bonsai 2.9 there are new shortcuts which have not been added yet, so pause on the review while I work on adding them. Edit: I am also now discovering that some of them were changed (e.g., Ctrl>+N opens a new window instead of a new workflow) so I will need to re-check the keyboard shortcuts. |
Also edited the text for grammar and clarity and removed N/A actions and shortcuts
b5bfc42
to
0b51eab
Compare
Ok I updated the PR with the new actions and shortcuts for bonsai 2.9. The list of actions and shortcuts are a bit long, especially on the mouse controls side, I was being comprehensive and wanted to make sure I had the same coverage for both mouse and keyboard controls, but we can drop some of them if they are really obvious ( stuff like pressing X to close a visualizer or window) or are covered in the article already. Also for the same reason (length) i did not cover the follow controls but they can be added back in for completeness. Save as workflow (extension) - Ctrl + Shift + S |
Updated based on feedback from DCM! |
Fixes #108. This PR expands and reformats the "Commands and Shortcuts" for improved readability. At the same time it adds some commonly used shortcuts that are missing. The list of changes:
commands
toactions
actions
might make more sense thancommands
actions
andkeyboard shortcuts
actions
namesactions
from keyboard shortcutsactions
, but for now I have opted to group them together with thePoint-and-Click
columnPoint-and-Click
column (maybe necessary for novices)Keyboard Shortcuts
column (fits established patterns, not necessary for more experienced people)actions
make explicit reference to a panel while others did not, I have added a panel item to allOnline preview