Fix yield for ESP8266#81
Closed
g3rb3n wants to merge 2 commits into
Closed
Conversation
Contributor
|
Dear @g3rb3n, we fixed these kinds of issues by introducing a Please let us know if you still have issues with the current version of this library, otherwise enjoy and thanks again! With kind regards, P.S.: As being superseded by merging #123, we might close this now. |
Author
|
Hi Andreas, delay(0) has a WDT feed as a side effect, so this will work fine as well. And it does save us a macro statement. Kind regards, Gerben |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The yield code seems to make my ESP's crash. The ESP has a watch dog timer feed function for long running processes. I have implemented this for the ESP8266 only by using macros. I have tested this on the ESP8266, but I did not check if it has any side effects for other boards.
Cheers!