'set_gain' returns the last value of 'read'#55
Open
Nagasaki45 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two load cells are connected to one HX711 it is a trivial use case to read both channels in a loop. Currently it looks something like this:
In such scenario, under the hood there are 4 calls to
readwhich slow down everything significantly.With this change, this use case can be solved efficiently with:
I know that it an awefull interface to work with, as the
set_scalemethod already does too many things. However, I couldn't find a better yet simple way to both read and update efficiently. If you have a better solution I would like to hear!Note that this change shouldn't break existing code (AFAIK, I'm not a C++ dev).