Skip to content

Raise CMake minimum version to 3.20 - #268

Draft
MrAureliusR wants to merge 1 commit into
boatbod:masterfrom
MrAureliusR:cmake_ver_update
Draft

Raise CMake minimum version to 3.20#268
MrAureliusR wants to merge 1 commit into
boatbod:masterfrom
MrAureliusR:cmake_ver_update

Conversation

@MrAureliusR

Copy link
Copy Markdown

This will fix a lot of build errors people are having. I picked 3.20 but this is easily change if some distros are still using older versions of CMake.

@MrAureliusR
MrAureliusR marked this pull request as draft February 13, 2026 22:30
@MrAureliusR

Copy link
Copy Markdown
Author

Converted to draft PR because this uncovered other issues with the CMake settings.

@MrAureliusR

Copy link
Copy Markdown
Author

Aw man I forgot all about this. Unfortunately right now I don't have the time to follow up, but essentially what happened was:

  • I bumped the CMAKE_MINIMUM_VERSION to 3.20
  • Because of the API changes since pre-3.5 compared to 3.20, this triggered other warnings/errors
  • Essentially, some syntax in CMakeLists.txt needs to be updated to reflect the changes in the API. The longer this goes, the more broken it'll get. Better to try and maintain compatibility with the latest CMake API
  • Once it's building cleanly without any spurious warnings, then re-submit as a PR here. You can start with my branch or fork the current state

@boatbod

boatbod commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Once you tell me you have a PR against my "dev" branch I'll take a look.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants