Skip to content

Use full path for inputs. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use full path for inputs. #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47716cf
Use full path for inputs.
everdark Jul 25, 2020
909dcd0
Better interface for expert use.
everdark Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions R/sentencepiece.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#' You can change the name of the model by providing the \code{model_prefix} argument.
#' @param model_dir directory where the model will be saved. Defaults to the temporary directory (tempdir())
#' @param threads integer indicating number of threads to use when building the model
#' @param args character string with arguments passed on to sentencepiece::SentencePieceTrainer::Train (for expert use only)
#' @param args character string with arguments passed on to sentencepiece::SentencePieceTrainer::Train (for expert use only, all other arguments will be ignored except for verbose)
#' @param verbose logical indicating to show progress of sentencepiece training. Defaults to \code{FALSE}.
#' @return an object of class \code{sentencepiece} which is defined at \code{\link{sentencepiece_load_model}}
#' @seealso \code{\link{sentencepiece_load_model}}
Expand Down Expand Up @@ -60,33 +60,35 @@
sentencepiece <- function(x, type = c("bpe", "char", "unigram", "word"), vocab_size = 8000, coverage = 0.9999,
model_prefix = "sentencepiece",
model_dir = tempdir(), threads = 1L, args, verbose = FALSE){
oldwd <- getwd()
on.exit(setwd(oldwd))
setwd(model_dir)
if(grepl(pattern = " ", model_prefix)){
stop("model_prefix should not contain spaces")
}
type <- match.arg(type)
if(missing(args)){
x <- normalizePath(x)
oldwd <- getwd()
on.exit(setwd(oldwd))
setwd(model_dir)
if(grepl(pattern = " ", model_prefix)){
stop("model_prefix should not contain spaces")
}
type <- match.arg(type)
stopifnot(is.character(x))
stopifnot(all(file.exists(x)))
args <- sprintf("--input=%s --model_prefix=%s --vocab_size=%s --character_coverage=%s --model_type=%s", paste(x, collapse=","), model_prefix, vocab_size, coverage, type)
model_file <- file.path(getwd(), sprintf("%s.model", model_prefix))
}else{
args <- as.character(args)
model_prefix <- regmatches(args, regexpr(args, pattern = "model_prefix=.+ -"))
model_prefix <- regmatches(args, regexpr(args, pattern = "model_prefix=.+( -|$)"))
model_prefix <- gsub("^model_prefix=|-$", "", model_prefix)
model_prefix <- gsub(" +$", "", model_prefix)
if(length(model_prefix) == 0 || nchar(model_prefix) == 0){
stop("Please provide at least model_prefix")
}
model_file <- sprintf("%s.model", model_prefix)
}
if(verbose){
result <- spc_train(args)
}else{
msg <- capture.output(result <- spc_train(args))
}
model <- file.path(getwd(), sprintf("%s.model", model_prefix))
result <- sentencepiece_load_model(file = model)
result <- sentencepiece_load_model(file = model_file)
result
}

Expand Down