Merged
Conversation
* Fix package exclusion with sibling targets and xcconfig flag stripping Previously, the App Clip target was generated nested inside the main app target in the Podfile. This caused it to inherit all pods from the parent, rendering `excludedPackages` completely ineffective. This change moves the App Clip target to the top level as a sibling of the main target, preventing implicit dependency inheritance. However, even with the target un-nested, CocoaPods still emits linker flags for all resolved pods into the generated `.xcconfig` files. This is especially problematic under new architecture + static frameworks, where Codegen headers are expected to exist for any linked package — causing "file not found" build failures. To address this, a `post_install` hook is injected that: 1. Removes excluded packages from the App Clip target's dependency graph 2. Strips all corresponding linker flags (`-l"Pkg"`, `-framework "Pkg"`) directly from the generated xcconfig files via `Xcodeproj::Config` This two-pronged approach ensures excluded packages are absent from both the build graph and the linker invocation, regardless of project settings. Fixes #81, #79 * Add documentation about `excludedPackages` option * Remove post_install xcconfig stripping (unnecessary after target un-nesting) Once the App Clip target is a sibling rather than nested inside the main target, `use_expo_modules!(exclude:)` fully prevents excluded packages from being installed or linked. The `post_install` hook that manually stripped OTHER_LDFLAGS was compensating for inherited linker flags that no longer exist. * Append target to end of Podfile without anchor Rather than relying on an anchor that may change with later versions of Expo, we now just append the App Clip target to the end of the Podfile. This also removes dependency on Expo 53+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request houses the changes queued for v0.8.0!